4 ms·

What's the point of leaving a review comment then?

• 1718627440 1y ago
  Because it belongs in to the PR and only the Author knows the answer: his thoughts and rationale for the change and behaviour. Sure I could just guess, but then it's essentially poking in legacy code. The point of it being not legacy code is, that the person is still around, so he should write down his reasons, so that they are documented.
  • dns_snek 1y ago
    Sure, what I'm trying to say is that you need to design a process which ensures that these non-blocking review comments get organized properly, and enforce it. If you need the author to add your comments to TODO.md then that should once again become a blocking review.
    • 1718627440 1y ago
      I do not want to prescribe the author what he needs to do. I only want to make sure that it was an intentional choice to not do that.