4 ms·

I still fail to see how different it is from overriding a blocking review for instance. The PR's author will always have ways around dealing with someone's fee

I still fail to see how different it is from overriding a blocking review for instance. The PR's author will always have ways around dealing with someone's feedback, and I think they should, otherwise there would be too many deadlocks (especially during incident respons etc.) I general I prefer teams where devs give a shit and seek feedback as a positive. In my current job we allow deployment of self approved MRs in that spirit.

BugsJustFindMe 11mo ago
There's a massive difference in communicated intent between overriding a blocking review and not blocking at all. Not blocking is a signal that you have no objection to merging the change as is.
- 1718627440 11mo ago
  > Not blocking is a signal that you have no objection to merging the change as is. Only when that is you social agreement. To others this has the meaning of "objection, but not rejection".
  - BugsJustFindMe 11mo ago
    If it makes you feel better, just think of ignoring non-blocking comments as equivalent to reading them and disagreeing.
    - 1718627440 11mo ago
      And this is what I think they are for. Just document that disagreement, and you have also countered future questions about this.
      - BugsJustFindMe 11mo ago
        "no" If you care about whether your concerns are addressed by further discussion, block. If you don't actually care about whether something happens as indicated by not blocking, it's passive aggressive to expect more work. People forget that you can just as easily block pending responses to comments and then approve after.
        1718627440 11mo ago
        > If you care about whether your concerns are addressed by further discussion, block. Well yes, but I don't care about them being addressed by discussion, I want them being addressed by your decision. > it's passive aggressive to expect more work. I am not sure what exactly "passive aggressive" is supposed to mean, but you generally get paid so that others can expect more work.
        BugsJustFindMe 11mo ago
        > I want them being addressed by your decision Sure, ok, so then they're addressed by the decision to ignore them because you don't care enough about them to make them blocking and there are other things to work on.
        1718627440 11mo ago
        If you documented this and provide a valid rationale for ignoring the issue, then the comment did it's job.
        BugsJustFindMe 11mo ago
        > If you documented this and provide I think your understanding of "ignore them" is different than mine. When I say ignore them I mean ignore them, not do more labor to document a thought process in response to them which is the opposite of ignoring them.
        1718627440 11mo ago

BugsJustFindMe 11mo ago

There's a massive difference in communicated intent between overriding a blocking review and not blocking at all. Not blocking is a signal that you have no objection to merging the change as is.

1718627440 11mo ago
> Not blocking is a signal that you have no objection to merging the change as is. Only when that is you social agreement. To others this has the meaning of "objection, but not rejection".
- BugsJustFindMe 11mo ago
  If it makes you feel better, just think of ignoring non-blocking comments as equivalent to reading them and disagreeing.
  - 1718627440 11mo ago
    And this is what I think they are for. Just document that disagreement, and you have also countered future questions about this.
    - BugsJustFindMe 11mo ago
      "no" If you care about whether your concerns are addressed by further discussion, block. If you don't actually care about whether something happens as indicated by not blocking, it's passive aggressive to expect more work. People forget that you can just as easily block pending responses to comments and then approve after.
      - 1718627440 11mo ago
        > If you care about whether your concerns are addressed by further discussion, block. Well yes, but I don't care about them being addressed by discussion, I want them being addressed by your decision. > it's passive aggressive to expect more work. I am not sure what exactly "passive aggressive" is supposed to mean, but you generally get paid so that others can expect more work.
        BugsJustFindMe 11mo ago
        > I want them being addressed by your decision Sure, ok, so then they're addressed by the decision to ignore them because you don't care enough about them to make them blocking and there are other things to work on.
        1718627440 11mo ago
        If you documented this and provide a valid rationale for ignoring the issue, then the comment did it's job.
        BugsJustFindMe 11mo ago
        > If you documented this and provide I think your understanding of "ignore them" is different than mine. When I say ignore them I mean ignore them, not do more labor to document a thought process in response to them which is the opposite of ignoring them.
        1718627440 11mo ago