5 ms·
I contributed to an OSS project recently that ran the linter before the tests and it absolutely trashed my code-build-test cycle. If I felt less strongly about
by hinkley 1y ago
I contributed to an OSS project recently that ran the linter before the tests and it absolutely trashed my code-build-test cycle. If I felt less strongly about the value of the project I would have bailed.
If I’m trying to get the code to work don’t cockblock me on Make it Work with your Make it Right enforcements.
- bbu 1y agoI’ve heard this argument before but I don’t get it. It’s trivial to setup your code editor to format on save. Why do people not do that but rather complain about files linter checks on CI?
- 1718627440 1y agoI don't think they were talking about formatting issues, since these tend to not change the behaviour of the code (outside of Python) so that you can't use the tests before addressing the linter issues.
- hinkley 1y agoBiome can fail the lint process if there’s an extra new line. Or you shortened a line that it thinks shouldn’t be wrapped anymore, or you added an argument to a line that it thinks should. I hates it.
- hinkley 1y agoIt’s trivial to set up my code editor to save to the format of six different GitHub repos? Do tell. One of them uses tabs. Fucking Richard.
- rcxdude 1y agoThat is a bit overzealous. It makes sense for CI where you don't want to waste running tests on an already failing build, but for local builds you probably want to allow warnings and be able to run tests, lints, and formatting checks separately.
- hinkley 1y agoI will probably file a PR to flip them around. Since the runscript will stop on a broken test it’ll work better for local. And then there’s the duplication and differences between the runscripts and the GitHub actions…