3 ms·

Could parsing the `-r` be added without noticing it somehow? If it was added in bulk, with many other still unsupported option names, why does the program not

• aw1621107 1y ago
  At least from what I can find, here's the original version of the changed snippet [0]: let date_source = if let Some(date) = matches.value_of(OPT_DATE) { DateSource::Custom(date.into()) } else if let Some(file) = matches.value_of(OPT_FILE) { DateSource::File(file.into()) } else { DateSource::Now }; And after `-r` support was added (among other changes) [1]: let date_source = if let Some(date) = matches.get_one::<String>(OPT_DATE) { DateSource::Human(date.into()) } else if let Some(file) = matches.get_one::<String>(OPT_FILE) { match file.as_ref() { "-" => DateSource::Stdin, _ => DateSource::File(file.into()), } } else if let Some(file) = matches.get_one::<String>(OPT_REFERENCE) { DateSource::FileMtime(file.into()) } else { DateSource::Now }; Still the same fallback. Not sure one can discern from just looking at the code (and without knowing more about the context, in my case) whether the choice of fallback was intentional and handling the flag was forgotten about. [0]: https://github.com/yuankunzhang/coreutils/commit/850bd9c32d91ea4f933d2f4d3aae5c4b79a71e6f https://github.com/yuankunzhang/coreutils/commit/850bd9c32d9... [1]: https://github.com/yuankunzhang/coreutils/blob/88a7fa7adfa048dabdffc99451d7aba1d9e6a9b6/src/uu/date/src/date.rs https://github.com/yuankunzhang/coreutils/blob/88a7fa7adfa04...
• zahlman 1y ago
  > Accepting an unsupported option and silently ignoring it is not, it takes a deliberate and obviously wrong action. No, it doesn't. For example, you could have code that recognizes that something "is an option", and silently discards anything that isn't on the recognized list.
  • 1718627440 1y ago
    > silently discards anything that isn't on the recognized list. That's a deliberate action.