5 ms·

https://github.com/currentspace/capn-rs/blob/main/capnweb-core/src/ids.rs https://github.com/currentspace/capn-rs/blob/main/capnweb-co... mmm delicious slop ma

• no_circuit 1y ago
  Right, for example, there are no comments on why something there is something called a PromiseIdAllocator that starts with the magic number "1": https://github.com/currentspace/capn-rs/blob/a816bfca5fb6ae5ce957c3db849bf3842447bd19/capnweb-core/src/ids.rs#L113-L117 https://github.com/currentspace/capn-rs/blob/a816bfca5fb6ae5... Yet there is a public interface that allows for initialization with "0": https://github.com/currentspace/capn-rs/blob/a816bfca5fb6ae5ce957c3db849bf3842447bd19/capnweb-core/src/ids.rs#L28-L30 https://github.com/currentspace/capn-rs/blob/a816bfca5fb6ae5... It's like the LLM was able to predict that 1 is needed in the protocol, but wasn't relevant to check in the boilerplate. I don't have a problem with newtype-all-the-things to ensure correctness in some areas, but no comments/constants does not lead to confidence.
• scottydelta 1y ago
  So we are allowing Claude to make commits now? Smh