3 ms·
My guide to good PRs: - Keep PR messages short and to the point. - use as many commits as you need, it's all the same branch. Squash if you want, I think it h
by btreecat 1y ago
My guide to good PRs:
- Keep PR messages short and to the point.
- use as many commits as you need, it's all the same branch. Squash if you want, I think it hides valuable meta.
- put the ticket in the branch name. Non negotiable.
- Update your ticket with progres. Put as much details as you can, as if you were writing to someone who's picking up the task after you.
- add links to your ticket. Docs, readme, o11y graphs, etc.
- Link ticket in PR for easy access to additional info
- Admit if you don't understand what your looking at. Better to pair and keep moving forward.
- if you request changes, stay available for conversation and approval for the next few hours.
- punt the review if you don't feel like you can legitimately engage with the content right now. Make sure you communicate it though.
- Avoid nits. This causes a loss in momentum and v rarely is worth changing.