4 ms·
Cool stuff! I can see some GPT comments that can be removed // Increased for better learning this doesn't tell me anything // Use the constants from lib.rs
by ramon156 1y ago
Cool stuff! I can see some GPT comments that can be removed
// Increased for better learning
this doesn't tell me anything
// Use the constants from lib.rs
const MAX_SEQ_LEN: usize = 80;
const EMBEDDING_DIM: usize = 128;
const HIDDEN_DIM: usize = 256;
these are already defined in lib.rs, why not use them (as the comment suggests)
- sloppytoppy 1y ago[flagged]
- deleted 1y ago[deleted]
- tialaramex 1y agoFor the constants is it possible the author didn't know how? I remember in my first week of Rust I didn't understand how to name things properly, basically I was overthinking it.
- vlovich123 1y agoLots of signs this is an LLM-generated project. All the emojis in the README are a hint as well.
- tayo42 1y agoFrom his reddit post https://old.reddit.com/r/rust/comments/1nguv1a/i_built_an_llm_from_scratch_in_rust_just_ndarray/ne8hu1m/ https://old.reddit.com/r/rust/comments/1nguv1a/i_built_an_ll...
- ericdotlee 1y agoDo you think vibe coded rust will rot the quality of language code generally?
- adastra22 1y agoThese things will be corrected over time.
- yahoozoo 1y agoHow do you mean?
- 6r17 1y agoFor AI you definitely need to clean up and I think even targeted learning on some practices would be beneficiary ; for users ; it depends on the people, and I'd argue that vibe-coded rust can be better than just "written-rust" IF the important details and mind of the user are actually focused on what is important ; Eg ; I could vibe-code a lock-free well architect-ed s3 - focus on all the important details that would actually make it high perf - or write some stuff myself 10x slower - which means I will have 10 x less time to work on the important stuff. However what you asked is wether the vibe coded rust will rot the quality of language ; this is a more difficult to answer to, but I don't think that people who are uninterested in the technics are going to go for rust anyway - from the signals I feedback people are actually not really liking it - they find it too difficult for some reason and prefer to blanket with stuff like C# or python. Can't explain why.
- miki123211 1y ago> I'd argue that vibe-coded rust can be better than just "written-rust I never thought about it this way, but it actually makes sense. It's just like how Rust / Go / Java / C# can sometimes be orders of magnitude faster than C, only because they're more expressive languages. If you have a limited amount of time, it may be possible to write an efficient, optimal and concurrent algorithm in Java, while in C, all you can do is the simplest possible solution. Linked list versus slices (which are much more cache-friendly) is the perfect example here.
- ramon156 1y agoVibe coded is fine, but keep the comments useful. GPT's are so quick with putting a comment on everything that it kind of enriches your codebase with slop. I wouldn't call it rotting, but definitely redundant
- tmaly 1y agodid you add these as a PR ?
- leoh 1y agoThey should stay, because they are indicative of the fact that this wasn't built with actual understanding.
- mitchitized 1y agoYou're absolutely correct!