2 ms·
As a former LLVM developer and reviewer, I want to say: 1. Good for you. 2. Ignore the haters in the comments. > my latest PR is my second-ever to LLVM and i
by jlebar 1y ago
As a former LLVM developer and reviewer, I want to say:
1. Good for you.
2. Ignore the haters in the comments.
> my latest PR is my second-ever to LLVM and is an entire linter check.
That is so awesome.
> The code is of terrible quality and I am at 100+ comments on my latest PR.
The LLVM reviewers are big kids. They know how to ignore a PR if they don't want to review it. Don't feel bad about wasting people's time. They'll let you know.
You might be surprised how many PRs even pre-LLMs had 100+ comments. There's a lot to learn. You clearly want to learn, so you'll get there and will soon be offering a net-positive contribution to this community (or the next one you join), if you aren't already.
Best of luck on your journey.
- jjmarr 1y agoThanks. I graduated 3 months ago and this has been a huge help.
- thesz 1y ago> You might be surprised how many PRs even pre-LLMs had 100+ comments What about percentages?
- close04 1y ago> They know how to ignore a PR if they don't want to review it How well does that scale as the number of such contributions increases and the triage process itself becomes a sizable effort? LLMs can inadvertently create a sort of DDoS even with the best intentions, and mitigating it costs something.
- sampullman 1y agoWait and see, then change the policy based on what actually happens. I sort of doubt that all of a sudden there's going to be tons of people wanting to make complex AI contributions to LLVM, but if there are just ban them at that point.
- yeasku 1y agoIt has happend to Curl.
- danillonunes 1y agoCurl's case was related with its bug bounty, so when involving money the incentives are different.