3 ms·
What issue are you taking with the code? Line breaks in the condition? Presumably the last if statement in the diff.
by machinate 1y ago
What issue are you taking with the code? Line breaks in the condition?
Presumably the last if statement in the diff.
- azinman2 1y agoThere aren’t {} brackets after the if
- machinate 1y agoAre you saying they should always be present? Or only when the condition takes multiple lines; i.e. do you take issue with the ifs in zone_name_pref too? Personally I think the indentation does a good enough job here.
- azinman2 1y agoYes I’m saying they should always be present. It is known to otherwise be error prone, which is why new c-like languages do not permit this (eg go) nor do many style guides (https://google.github.io/styleguide/cppguide.html#Formatting_Looping_Branching https://google.github.io/styleguide/cppguide.html#Formatting...)