3 ms·
And by "garbage" I mean it. Linus
- rwmj 1y agoIt's worth reading Palmer's reply, which is a correct response: https://lore.kernel.org/lkml/mhng-655602B8-F102-4B0F-AF4A-4AB94A9F231F@Palmers-Mini.rwc.dabbelt.com/ https://lore.kernel.org/lkml/mhng-655602B8-F102-4B0F-AF4A-4A... (Palmer is a super-smart and nice guy who I have worked with, and IMHO didn't deserve this little rant from Linus, but he made a mistake, owned up to it, and didn't make a fuss.)
- nneonneo 1y agoThis is the full patchset: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/diff/?h=riscv-for-linus-6.17-mw1&id2=89be9a83ccf1f88522317ce02f854f30d6115c41 https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.... The offending macros are defined in include/linux/wordpart.h: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/diff/include/linux/wordpart.h?h=riscv-for-linus-6.17-mw1&id2=89be9a83ccf1f88522317ce02f854f30d6115c41 https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.... I'd generally agree with Linus that these are confusing to use. It's not clear if you would pass (hi, lo) or (lo, hi) without looking at the definition of the macro; all of the other macros in that function are very clear about what they will produce.
- abstractspoon 1y agoLinus acts like such a dick sometimes