3 ms·

That would flag a huge percentage of JS packages that ship with minified code.

• jay_kyburz 1y ago
  How are people verifying their dependencies if they are minified?
  • SethTro 1y ago
    That's the magic part, they aren't
  • chatmasta 1y ago
    My guy… in the JS ecosystem a “lock file” is something that restricts your package installer to an arbitrary range of packages, i.e. no restrictions at all and completely unpredictable. You have to go out of your way to “pin” a package to a specific version.
    • Izkata 1y ago
      Lockfiles use exact hashes, not versions/version ranges. Javascript projects use two files, a package file with version ranges (used when upgrading) and a lockfile with the exact version (used in general when installing in an existing project).
      • zdragnar 1y ago
        NPM is rather infamous for not exactly respecting the lockfile, however.
      • chatmasta 1y ago
        Sure, but a lockfile with a hash doesn’t mean that next time it will fail if it tries to install a version of the package without that hash. If your package.json specifies a semver range then it’ll pull the latest minor or patch version (which is what happened in this case with e.g. duckdb@1.3.3) and ignore any hash differences if the version has changed. Hence why I say you need to go out of your way to specify an exact version in package.json and then the lock file will work as you might expect a “lock” file to work. (Back when I was an engineer and not a PM with deteriorating coding ability, I had to make a yarn plugin to pin each of our dependencies.) The best way to manage JS dependencies is to pin them to exact versions and rely on renovate bot to update them. Then at least it’s your choice when your code changes. Ideally you can rebuild your project in a decade from now. But if that’s not possible then at least you should have a choice to accept or decline code changes in your dependencies. This is very hard to achieve by default in the JS ecosystem.
        • jay_kyburz 1y ago
          I think at some point you would be better off vendoring them in.
          • chatmasta 1y ago
            That’s effectively what I did in a very roundabout way with docker images and caching that ended up abusing the GitLab free tier for image hosting. When you put it like that it does make me think there was a simpler solution, lol. When I’m hacking on a C project and it’s got a bunch of code ripped out of another project, I’m like “heh, look at these primordial dependency management practices.” But five years later that thing is gonna compile no problem…
          • cluckindan 1y ago
            There’s even a command for that: npm pack
• cluckindan 1y ago
  Why would you be including minified code in a build? That’s just bad practice and makes development-time debugging more difficult.
• saghm 1y ago
  It's not like minified JS can't be parsed and processed as AST. You could still pretty easily split up each statement/assignment to check the length of each one individually.