3 ms·
There's got to be a bug because this was on the front page 6 days ago: http://news.ycombinator.com/item?id=4486108 http://news.ycombinator.com/item?id=4486108
by jyap 14y ago
There's got to be a bug because this was on the front page 6 days ago:
http://news.ycombinator.com/item?id=4486108 http://news.ycombinator.com/item?id=4486108
Well the link in the previous post had a trailing slash.
- deleted 14y ago[deleted]
- tylermauthe 14y agoFunny part is that this submission made it to the front page again... I guess this is a really popular topic?
- pdenya 14y agoIt's a really popular headline at least. The actual article i'm not impressed with but email regexes are a pain.
- crisnoble 14y agoSo to sum up the comments on the previous submission: 1) Someone did make a fully compliant Regex https://github.com/larb/email_address_validator https://github.com/larb/email_address_validator 2) Lots of people (including the author http://news.ycombinator.com/item?id=4486264 http://news.ycombinator.com/item?id=4486264) think that you should at least validate that the '@' is somewhere to avoid username / email mixups 3) If your regex fails for foo+tag@something.com lots of people get pissed. I learned you can use that for inbox sorting since foo+tag@something.com goes to foo@something.com. 4) There are other schools of thought that promote validation and telling the user something is wrong like mailcheck.js (https://github.com/Kicksend/mailcheck https://github.com/Kicksend/mailcheck), but these should not stop users from submitting forms. Did I miss anything?
- ars 14y agoYes. 5) Do some basic validation. If it fails, ask the user: Are you sure this email address is correct? If they say yes, then allow it anyway. This lets you catch all the typos, without annoying people with more complicated email addresses.
- pbreit 14y agoThat the solution proposed kills conversion and is unnecessary.