2 ms·

> I think GitHub added the “pull request” as a really useful add on to git and that really made it take off. For the sake of correctness, the concept of pull r

by goku12 1y ago

> I think GitHub added the “pull request” as a really useful add on to git and that really made it take off. For the sake of correctness, the concept of pull requests was not introduced by Github. It already existed in git in the form of the 'request-pull' subcommand. The fundamental workflow is the same. You send the project maintainer a message requesting a pull of your changes from your own online clone repo. The difference is that the message was in the form of an email. Code reviews could be conducted using mails/mailing lists too. This is not the same as sending patches by email. But considering how people hate emails, I can see why it didn't catch on. However, Torvalds considered this implementation to be superior to Github's and once complained about the latter on Github itself [1]. [1] https://github.com/torvalds/linux/pull/17#issuecomment-5654674 https://github.com/torvalds/linux/pull/17#issuecomment-56546...

high_priest 1y ago
I am stunned by the fact at a 13+years old comment can be dug out, just like this, and presented as a valid argyment in a conversation. How some people, like you sir, are able to recall such minute events, is amazing.
- goku12 1y ago
  > How some people, like you sir, are able to recall such minute events, is amazing. Oh! That's easy. I forgot that it is 13+ years old! XD Added later: Your comment made me look up more details about it. It was a widely discussed comment at the time. The HN discussion about it is as interesting as the comment itself [1]. [1] https://news.ycombinator.com/item?id=3960876 https://news.ycombinator.com/item?id=3960876
ycombinatrix 1y ago
I still don't get the line wrapping hangup. Doesn't every modern text editor have an option to auto wrap existing text? Why should I manually limit text to an arbitrary 72 character width between newlines?

by goku12 1y ago

high_priest 1y ago

I am stunned by the fact at a 13+years old comment can be dug out, just like this, and presented as a valid argyment in a conversation. How some people, like you sir, are able to recall such minute events, is amazing.

goku12 1y ago
> How some people, like you sir, are able to recall such minute events, is amazing. Oh! That's easy. I forgot that it is 13+ years old! XD Added later: Your comment made me look up more details about it. It was a widely discussed comment at the time. The HN discussion about it is as interesting as the comment itself [1]. [1] https://news.ycombinator.com/item?id=3960876 https://news.ycombinator.com/item?id=3960876

ycombinatrix 1y ago

I still don't get the line wrapping hangup. Doesn't every modern text editor have an option to auto wrap existing text? Why should I manually limit text to an arbitrary 72 character width between newlines?