3 ms·
Oh, certainly, didn't mean that you had to avoid using your IDE to autorename a variable yourself (to avoid the boolean issue) and diffed results to those of th
by eviks 1y ago
Oh, certainly, didn't mean that you had to avoid using your IDE to autorename a variable yourself (to avoid the boolean issue) and diffed results to those of the PR
Or that you had to avoid Ctrl+F "CustomerEmail" and see whether you had 1000 matches that matches the number of changed files or only 999 due to some typo.
Or using the web interface to filter by file type to batch your reviews.
Or...
Just that in none of those cases there is anything close to our memory/attention capacity.
- deleted 1y ago[deleted]
- shadowgovt 1y agoI envy your IDE being able to do a rename of that scale. I work in a large C++ codebase and a rename like that will actually just crash my vscode instance straight-up. (There are good automated tools that make it straightforward to script up a repository-wide mutation like this however. But they still generate PRs that require human review; in the case of the one I used, it'd break the PR up into tranches of 50-ish files per tranche and then hunt down individuals with authority to review the root directory of the tranche and assign it to them. Quite useful!)
- trenchpilgrim 1y agoYeah VSCode is pretty terrible at refactorings that Jetbrains or Zed will do basically instantly.