3 ms·

I've read comments online (here on HN) that Github has been rewriting their UI in React and that it's got slower since. I have no knowledge if this is true or n

I've read comments online (here on HN) that Github has been rewriting their UI in React and that it's got slower since. I have no knowledge if this is true or not (ie React -> speed direct correlation), and my own projects are small enough not to see any performance impact. Does anyone have concrete information?

sleepytimetea 1y ago
They just pushed a new redesigned page for pull request diffs- must have bloated the DOM.
- mtmail 1y ago
  I still see a little "try the new experience" link on the PR diff page (top right of page) so the rollout might be gradual. I won't click.
  - walthamstow 1y ago
    I am such a masochist that I actually click those buttons. If it's good, great, if it's shit, I have time to adjust before they foist it upon me anyway
    - adithyassekhar 1y ago
      I am on insider previews and betas for all apps I use. You're not alone.
    - guappa 1y ago
      I prefer to delay the pain as much as possible instead
  - herpdyderp 1y ago
    I tried it! I like it generally, but it’s too buggy. The whole diff explodes if you expand to more lines (for example). It’s easy to switch back.
fleebee 1y ago
I came across a blog post[1] (HN thread[2]) recently that sheds some light on the issue. The tl;dr is that the PR view can render over 100 000 DOM nodes, many of which are invisible inline SVG nodes, and SPA routing makes navigation a lot slower. [1]: https://yoyo-code.com/why-is-github-ui-getting-so-much-slower/ https://yoyo-code.com/why-is-github-ui-getting-so-much-slowe... [2]: https://news.ycombinator.com/item?id=44799861 https://news.ycombinator.com/item?id=44799861
- joshmoody24 1y ago
  That blog post discovered that hard refreshing the page is faster than GitHub's SPA navigation, which led me to make this browser extension which makes GitHub navigation twice as fast: https://chromewebstore.google.com/detail/make-github-great-again/pblbdbcpfdpmhmcmgjmggdigeakhmend https://chromewebstore.google.com/detail/make-github-great-a...

sleepytimetea 1y ago

They just pushed a new redesigned page for pull request diffs- must have bloated the DOM.

mtmail 1y ago
I still see a little "try the new experience" link on the PR diff page (top right of page) so the rollout might be gradual. I won't click.
- walthamstow 1y ago
  I am such a masochist that I actually click those buttons. If it's good, great, if it's shit, I have time to adjust before they foist it upon me anyway
  - adithyassekhar 1y ago
    I am on insider previews and betas for all apps I use. You're not alone.
  - guappa 1y ago
    I prefer to delay the pain as much as possible instead
- herpdyderp 1y ago
  I tried it! I like it generally, but it’s too buggy. The whole diff explodes if you expand to more lines (for example). It’s easy to switch back.

fleebee 1y ago

I came across a blog post[1] (HN thread[2]) recently that sheds some light on the issue. The tl;dr is that the PR view can render over 100 000 DOM nodes, many of which are invisible inline SVG nodes, and SPA routing makes navigation a lot slower. [1]: https://yoyo-code.com/why-is-github-ui-getting-so-much-slower/ https://yoyo-code.com/why-is-github-ui-getting-so-much-slowe... [2]: https://news.ycombinator.com/item?id=44799861 https://news.ycombinator.com/item?id=44799861

joshmoody24 1y ago
That blog post discovered that hard refreshing the page is faster than GitHub's SPA navigation, which led me to make this browser extension which makes GitHub navigation twice as fast: https://chromewebstore.google.com/detail/make-github-great-again/pblbdbcpfdpmhmcmgjmggdigeakhmend https://chromewebstore.google.com/detail/make-github-great-a...