3 ms·
Don't optimize for these people.
by devin 1y ago
Don't optimize for these people.
- danielhanchen 1y agoYep agreed - I primarily thought it was a reasonable "hack", but it's pretty bad security wise, so apologies again. The current solution hopefully is in between - ie sudo is gone, apt-get will run only after the user agrees by pressing enter, and if it fails, it'll tell the user to read docs on installing llama.cpp
- woile 1y agoDon't apologize, you are doing amazing work. I appreciate the effort you put. Usually you don't make assumptions on the host OS, just try to find the things you need and if not, fail, ideally with good feedback. If you want to provide the "hack", you can still do it, but ideally behind a flag, `allow_installation` or something like that. This is, if you want your code to reach broader audiences.
- danielhanchen 1y agoThank you! :)
- shaan7 1y agoYep there's no need to apologize, you've been very courteous and took all that feedback constructively. Good stuff :)
- danielhanchen 1y agoThank you!
- deleted 1y ago[deleted]