3 ms·

You can't put up a PR if the gate keepers reject your whole design approach

• cuu508 1y ago
  As a gatekeeper in an unrelated small project, I understand gatekeepers being selective. You have a vision, design standards, quality standards. Drive-by PRs that add "just this one thing I need" features is how your well-designed, cohesive project becomes a kitchen sink of shit.
  • eviks 1y ago
    > You have a vision, design standards, quality standards. Unless, of course, all of those are shit, so a more design-competent person can drive by with an improvement, which will be rejected because it's too shiny
• gf000 1y ago
  Well, yeah. They have their own design approach, if you don't take that into consideration, aren't you the one that in the wrong?
  • eviks 1y ago
    You're not, that depends entirely on the assessment of the relative approaches and whom you care more about, users or a subset of designers closest to the gates. But that's beside the point, the point was the criticism of the "send a PR" even though that resolves nothing due to the mismatch.