3 ms·
> This took less than an hour while I was watching TV. I certainly could not review all of those changes in an uninterupted hour. I'd need to test the design c
by socalgal2 1y ago
> This took less than an hour while I was watching TV.
I certainly could not review all of those changes in an uninterupted hour. I'd need to test the design changes on multiple browsers, check they respond to zoom and window sizing. I'd have to read through the tests and check that they were not just nonsense and returning true to pass. There's no way I could do all that while watching TV in 1 hour.
- jama211 1y agoThis is for a janky backend admin panel, not a customer facing product. If it’s way better than it was before, which likely wasn’t responsive either, it’s a win. Understanding the context of a project is important.
- socalgal2 1y agoAnd the tests? To me, if it was something important enough to have tests for in which case it's important to check the tests are valid so I'd have to review them
- martinald 1y agoIt takes me 5 mins to review e2e UI tests and watch it go through them. It's literally filling fields and making sure certain things happen.
- jama211 1y agoI think you’re overestimating the complexity of the tests required here. But I take it from the rest of your comment that you understand my point.