4 ms·
A lot depends heavily on how you define productive. At one of my jobs, the PRs are far less reviewable, but now the devs write tests when they didn’t used to b
by throwawaysleep 1y ago
A lot depends heavily on how you define productive.
At one of my jobs, the PRs are far less reviewable, but now the devs write tests when they didn’t used to bother. I’ve always viewed reviewing PRs as work without recognition, so I never did much of it anyway, but but now that there are passing tests, I often approve without more than a cursory skim.
So yes, it has made their work more productive for me to get off my plane.
- skydhash 1y agoBut are the test actually useful? You can have a test suite that is actually harmful if it’s not ensuring business rules or domain correctness. Anything else makes for a brittle dev ecosystem.
- teiferer 1y agoThanks for this take. It perfectly illustrates the productivity illusion. Mostly blindly approving PRs mainly because they now contain some form of equally AI-generated tests is exactly the producticity fallacy that's the issue here.