3 ms·
Interns and new hires sometimes need a quick chat about actually looking at their changes before asking for a review, but that's about it in my experience. I gu
by plorkyeran 1y ago
Interns and new hires sometimes need a quick chat about actually looking at their changes before asking for a review, but that's about it in my experience. I guess it could be a problem for a project which accepts a large number of public PRs from mostly non-technical or beginner users?
- vdfs 1y agoIt's not a problem with PRs if you use Squash merge, the developer can make any number of changes to that PR but in the end, only the final version (in this case it doesn't include .DS_Store) will be commited. even the .DS_Store file will not be in the git index
- matheusmoreira 1y agoThat sacrifices the git history though. It turns the PR into a huge atomic change instead of a series of step-by-step changes that are easy to review.
- arcfour 1y agoYes, I have run into that once or twice but never to the extent that I would call it "sisyphean", haha.