3 ms·

How come this wasn't covered by one or more automated tests that failed?

by Cthulhu_ 1y ago

throwaway2037 1y ago
Yeah, crazy. Also, the bugfix does not include a test case.
- _mlbt 1y ago
  Feel free to contribute one. I’m sure the maintainers would welcome it… > If you want to participate in actively developing Apache please subscribe to the dev@httpd.apache.org mailing list as described at https://httpd.apache.org/lists.html#http-dev https://httpd.apache.org/lists.html#http-dev
whatevaa 1y ago
There are tests?
- Hilift 1y ago
  It is "CrowdTested".
  - oaiey 1y ago
    You already have a registered trademark? Will use that ;)
testplzignore 1y ago
Based on https://github.com/apache/httpd/commits?author=covener https://github.com/apache/httpd/commits?author=covener, either the committer never writes tests, or this project just doesn't do testing at all. Nothing here would pass a code review at my company. Totally insane.
- homebrewer 1y ago
  Your company, and others like it, are of course entitled to a refund. These infrastructural projects never get any funding when everything goes well, but when an overworked maintainer screws up in good faith, everybody piles on them. The attacks on OpenSSL maintainers ten years ago were disgusting, and I think we've learned nothing since then.
  - sshine 1y ago
    > The attacks on OpenSSL maintainers ten years ago were disgusting I didn't register the attacks, but I'm sure there were some when you say it. I summarized the blame on that incident xkcd's wording: "some random person has been thanklessly maintaining since 2003" https://xkcd.com/2347/ https://xkcd.com/2347/
  - Joker_vD 1y ago
    No, we've learned to stop using OpenSSL. And ASF does receive funding, by the way, even if not much (slightly less than two and a half million USD in 2024).
    - Macha 1y ago
      So let's pretend this only paid for employees. 5-15 employees depending on where they live. Let's assume 1-2 admin and 13 devs. A quick eyeball of the projects list looks like about 100 projects: https://projects.apache.org/projects.html https://projects.apache.org/projects.html So each project gets funded enough for 10% of a developer. That's not enough to provide infrastructure to commercial users satisfaction.
      - Joker_vD 1y ago
        Depends on what, exactly, the developers are doing with them projects! If those are in the "maintenance mode" (no new features, just fixing bugs and making sure it still builds with newer toolchains/ecosystems), then this amount of humanpower may be quite reasonable.
oaiey 1y ago
You mean Apache httpd ... the thing which is called a-patchy-httpd server? (that is not a joke!). Apache httpd existed many years before junit was invented in 1997. Long before TDD became a thing and our rigorous modern understanding set in. For a second, I even thought the Apache Foundation (founded because of httpd) later hosted junit, but I was wrong, is the Eclipse Foundation.
- sidewndr46 1y ago
  What does this have to do with Junit?
  - Macha 1y ago
    Junit was one of the first libraries to popularise modern patterns of unit testing. Some people were writing their own ad-hoc scaffolds before that but it wasn't a widespread practice. Testing meant manual testers clicking on things in the UI, and sophisticated testing was if you had checklists of things to test manually.
    - _mlbt 1y ago
      Perl has had a very pervasive testing culture that predates Junit by a decade… https://www.perl.org/about/whitepapers/perl-testing.html https://www.perl.org/about/whitepapers/perl-testing.html
  - oaiey 1y ago
    My apologies for that. I always forget I am old ;). What Macha said.
- PuercoPop 1y ago
  junit was not invented, it was a port from Smalltalk's SUnit, which was created on 1989, ~6 years before the first release of Apache. Yes, the extreme programming (XP) craze hadn't popularized TDD, but united testing as a practice already existed, even if only some communities. Though I agree, that although not a technical justification, an explanation as to why there are no tests is because Apache HTTP is from the 90's. Not writing unit tests was par for course back then. Most FLOSS code bases in the 90s didn't have unit tests, let a alone a CI to run the test suite for each change. Adding tests later is hard. Though there are some tests under the test folder.
csmpltn 1y ago
Welcome to open source software, the "year of the linux desktop", etc...

How come this wasn't covered by one or more automated tests that failed?

throwaway2037 1y ago

Yeah, crazy. Also, the bugfix does not include a test case.

_mlbt 1y ago
Feel free to contribute one. I’m sure the maintainers would welcome it… > If you want to participate in actively developing Apache please subscribe to the dev@httpd.apache.org mailing list as described at https://httpd.apache.org/lists.html#http-dev https://httpd.apache.org/lists.html#http-dev

whatevaa 1y ago

There are tests?

Hilift 1y ago
It is "CrowdTested".
- oaiey 1y ago
  You already have a registered trademark? Will use that ;)

testplzignore 1y ago

Based on https://github.com/apache/httpd/commits?author=covener https://github.com/apache/httpd/commits?author=covener, either the committer never writes tests, or this project just doesn't do testing at all. Nothing here would pass a code review at my company. Totally insane.

homebrewer 1y ago
Your company, and others like it, are of course entitled to a refund. These infrastructural projects never get any funding when everything goes well, but when an overworked maintainer screws up in good faith, everybody piles on them. The attacks on OpenSSL maintainers ten years ago were disgusting, and I think we've learned nothing since then.
- sshine 1y ago
  > The attacks on OpenSSL maintainers ten years ago were disgusting I didn't register the attacks, but I'm sure there were some when you say it. I summarized the blame on that incident xkcd's wording: "some random person has been thanklessly maintaining since 2003" https://xkcd.com/2347/ https://xkcd.com/2347/
- Joker_vD 1y ago
  No, we've learned to stop using OpenSSL. And ASF does receive funding, by the way, even if not much (slightly less than two and a half million USD in 2024).
  - Macha 1y ago
    So let's pretend this only paid for employees. 5-15 employees depending on where they live. Let's assume 1-2 admin and 13 devs. A quick eyeball of the projects list looks like about 100 projects: https://projects.apache.org/projects.html https://projects.apache.org/projects.html So each project gets funded enough for 10% of a developer. That's not enough to provide infrastructure to commercial users satisfaction.
    - Joker_vD 1y ago
      Depends on what, exactly, the developers are doing with them projects! If those are in the "maintenance mode" (no new features, just fixing bugs and making sure it still builds with newer toolchains/ecosystems), then this amount of humanpower may be quite reasonable.

oaiey 1y ago

You mean Apache httpd ... the thing which is called a-patchy-httpd server? (that is not a joke!). Apache httpd existed many years before junit was invented in 1997. Long before TDD became a thing and our rigorous modern understanding set in. For a second, I even thought the Apache Foundation (founded because of httpd) later hosted junit, but I was wrong, is the Eclipse Foundation.

sidewndr46 1y ago
What does this have to do with Junit?
- Macha 1y ago
  Junit was one of the first libraries to popularise modern patterns of unit testing. Some people were writing their own ad-hoc scaffolds before that but it wasn't a widespread practice. Testing meant manual testers clicking on things in the UI, and sophisticated testing was if you had checklists of things to test manually.
  - _mlbt 1y ago
    Perl has had a very pervasive testing culture that predates Junit by a decade… https://www.perl.org/about/whitepapers/perl-testing.html https://www.perl.org/about/whitepapers/perl-testing.html
- oaiey 1y ago
  My apologies for that. I always forget I am old ;). What Macha said.
PuercoPop 1y ago
junit was not invented, it was a port from Smalltalk's SUnit, which was created on 1989, ~6 years before the first release of Apache. Yes, the extreme programming (XP) craze hadn't popularized TDD, but united testing as a practice already existed, even if only some communities. Though I agree, that although not a technical justification, an explanation as to why there are no tests is because Apache HTTP is from the 90's. Not writing unit tests was par for course back then. Most FLOSS code bases in the 90s didn't have unit tests, let a alone a CI to run the test suite for each change. Adding tests later is hard. Though there are some tests under the test folder.

csmpltn 1y ago

Welcome to open source software, the "year of the linux desktop", etc...