5 ms·

AFAICT they were reviewed, but too leniently in light of his "improve the codebase" rhetoric. His recent drama and stirring has brought eyes from more senior me

AFAICT they were reviewed, but too leniently in light of his "improve the codebase" rhetoric. His recent drama and stirring has brought eyes from more senior members of the team, which realized his work was shotty and several changes being made were outright wrong or caused new bugs. More info here: https://www.phoronix.com/news/X.Org-Server-Lots-Of-Reverts https://www.phoronix.com/news/X.Org-Server-Lots-Of-Reverts

em-bee 1y ago
His recent drama and stirring has brought eyes from more senior members of the team that's what's bothering me. because someone misbehaves suddenly everything this person does receives more scrutiny. it should have received that scrutiny from the beginning. as should every other PR. the behavior or the character of a person should not affect how critical i review their code. that's discrimination. if this was a woman this reaction would be considered sexist. if the reason was that people actually reported issues and those issues would point to one persons submissions so that a track record of bad submissions builds up then it would be reasonable to wonder what else did this person do wrong. but drama and stirring is not a good reason to suddenly question someones ability as a coder.
- Tadpole9181 1y ago
  Realistically, any significant project can't do what you want. Linus cannot review every bit of code that enters the kernel, he delegates that task to trusted people. And they may themselves delegate further. If something breaks or some external force appears, Linus may review the work of the delegates more closely than normal. And that's often when we get his most memorable rants, when he tells people he's putting trust in to stop disappointing him because they know better. > The behavior or the character of a person should not affect how critical i review their code. that's discrimination. if this was a woman this reaction would be considered sexist. What are you even talking about? That's not what happened. Different reviewers, with higher standards for their project, who understand the code better are now looking. Their conclusion was "this code is awful and caused breaks". They aren't reviewing it any different than other code. Also, weird to bring up sexism. It is absolutely not the same to say I would refuse code from a Nazi apologist as to say I would refuse code from a woman.
  - em-bee 1y ago
    > The behavior or the character of a person should not affect how critical i review their code. What are you even talking about? That's not what happened. you said: His recent drama and stirring has brought eyes from more senior members of the team and that's my interpretation of that. did you mean something else? if i misunderstood you then i apologize. It is absolutely not the same to say I would refuse code from a Nazi apologist as to say I would refuse code from a woman. i disagree. especially if it is code that has already been accepted. besides, that's not what's happening here. the code is not summarily rejected. it is more critically scrutinized. and doing that is absolutely the same thing as more critically scrutinizing someones code because of their gender. so the nazi excuse doesn't work.

em-bee 1y ago

His recent drama and stirring has brought eyes from more senior members of the team that's what's bothering me. because someone misbehaves suddenly everything this person does receives more scrutiny. it should have received that scrutiny from the beginning. as should every other PR. the behavior or the character of a person should not affect how critical i review their code. that's discrimination. if this was a woman this reaction would be considered sexist. if the reason was that people actually reported issues and those issues would point to one persons submissions so that a track record of bad submissions builds up then it would be reasonable to wonder what else did this person do wrong. but drama and stirring is not a good reason to suddenly question someones ability as a coder.

Tadpole9181 1y ago
Realistically, any significant project can't do what you want. Linus cannot review every bit of code that enters the kernel, he delegates that task to trusted people. And they may themselves delegate further. If something breaks or some external force appears, Linus may review the work of the delegates more closely than normal. And that's often when we get his most memorable rants, when he tells people he's putting trust in to stop disappointing him because they know better. > The behavior or the character of a person should not affect how critical i review their code. that's discrimination. if this was a woman this reaction would be considered sexist. What are you even talking about? That's not what happened. Different reviewers, with higher standards for their project, who understand the code better are now looking. Their conclusion was "this code is awful and caused breaks". They aren't reviewing it any different than other code. Also, weird to bring up sexism. It is absolutely not the same to say I would refuse code from a Nazi apologist as to say I would refuse code from a woman.
- em-bee 1y ago
  > The behavior or the character of a person should not affect how critical i review their code. What are you even talking about? That's not what happened. you said: His recent drama and stirring has brought eyes from more senior members of the team and that's my interpretation of that. did you mean something else? if i misunderstood you then i apologize. It is absolutely not the same to say I would refuse code from a Nazi apologist as to say I would refuse code from a woman. i disagree. especially if it is code that has already been accepted. besides, that's not what's happening here. the code is not summarily rejected. it is more critically scrutinized. and doing that is absolutely the same thing as more critically scrutinizing someones code because of their gender. so the nazi excuse doesn't work.