4 ms·

> 14.7MB You know, a patch file can individually address each upsteam file it intends to modify, right? I presume someone who wants to casually read them would

> 14.7MB You know, a patch file can individually address each upsteam file it intends to modify, right? I presume someone who wants to casually read them would need to fork the repo, cut up the ginormous .patch file into the 2361 individual patches for ease of reading or deep-linking I also just for-real don't understand how in the universe a ~15MB text file against an open source _git hosted_ project is a sane way of delivering value. Not a single time in the readme did they say why $(git diff origin/tags/8.0.42...HEAD > yolo.patch) was the chosen delivery mechanism

throwdbaaway 1y ago
https://github.com/google/mysql-tools/tree/master/old/mysql-patches https://github.com/google/mysql-tools/tree/master/old/mysql-... - Google used to do that too
- mdaniel 1y ago
  Well, if Google does it then I guess I stand corrected about it being a weirdo way to deliver patches. They went so far as to .gz theirs, too, for extra non-browsing by mere mortals. I find it curious that <https://github.com/google/mysql-tools/blob/02d18542735a528c4a6cca951207393383266bb9/COPYING https://github.com/google/mysql-tools/blob/02d18542735a528c4...> and yet <https://github.com/google/mysql-tools/blob/02d18542735a528c4a6cca951207393383266bb9/old/mysql-patches/mysql-4.0.26-patches#L1 https://github.com/google/mysql-tools/blob/02d18542735a528c4...> says "diff -ruN base/client/mysqldump.c mysql40gpl/client/mysqldump.c" I had no idea one could release patches of GPL software under an Apache license. That makes my head hurt.
  - theMMaI 1y ago
    For Google it's undoubtedly only done because under the license agreement they must make their source code modifications available if someone asks. A form of malicious compliance if you wish
fipar 1y ago
MySQL is available in GitHub (so in that sense hosted) but development doesn’t happen there. Not saying that’s the reason for the delivery mechanism though.

throwdbaaway 1y ago

https://github.com/google/mysql-tools/tree/master/old/mysql-patches https://github.com/google/mysql-tools/tree/master/old/mysql-... - Google used to do that too

mdaniel 1y ago
Well, if Google does it then I guess I stand corrected about it being a weirdo way to deliver patches. They went so far as to .gz theirs, too, for extra non-browsing by mere mortals. I find it curious that <https://github.com/google/mysql-tools/blob/02d18542735a528c4a6cca951207393383266bb9/COPYING https://github.com/google/mysql-tools/blob/02d18542735a528c4...> and yet <https://github.com/google/mysql-tools/blob/02d18542735a528c4a6cca951207393383266bb9/old/mysql-patches/mysql-4.0.26-patches#L1 https://github.com/google/mysql-tools/blob/02d18542735a528c4...> says "diff -ruN base/client/mysqldump.c mysql40gpl/client/mysqldump.c" I had no idea one could release patches of GPL software under an Apache license. That makes my head hurt.
- theMMaI 1y ago
  For Google it's undoubtedly only done because under the license agreement they must make their source code modifications available if someone asks. A form of malicious compliance if you wish

fipar 1y ago

MySQL is available in GitHub (so in that sense hosted) but development doesn’t happen there. Not saying that’s the reason for the delivery mechanism though.