3 ms·
You should be doing this dynamically based on the version of python you are running against, so that you don't have to hardcode or make such "conservative" choi
by zo1 1y ago
You should be doing this dynamically based on the version of python you are running against, so that you don't have to hardcode or make such "conservative" choices by hand.
- lacasito25 1y agoI think they probably know that, this is alpha software, no need to be condescending.
- lionkor 1y agoThey said they will default to some newer version, which indicates they are not planning to do this dynamically.
- zarathustreal 1y agoCriticism isn’t necessarily condescending. “You should be doing x because y” is just a plain assertion, it doesn’t imply any moral judgement or opinion of the author.
- johnisgood 1y agoHow is it condescending in any way? I found it to be a constructive criticism; i.e. useful help.
- mahogany 1y agoI don't necessarily read it as condescending, but I do read it as presumptuous. What someone "should" do depends on many things. Maybe, because this is software in alpha stage, they should _not_ focus on this part of the code if it is minor compared to other obligations. Or maybe there are other reasons they've chosen not to do this (as was explained in an above comment). IMO, a less presumptuous criticism would be phrased like "if you did X then benefits Y would happen", or "if you haven't, consider X", or even (the least presumptuous - make it a conversation!) "have you considered X?", rather than "you should do X".
- johnisgood 1y agoI see what you mean. Perhaps it was just a "poor" choice of words for whatever reasons. I am sure we can assume he intended it in a way of "have you considered X?".
- dcreager 1y agoNote that we're not ever spinning up a Python interpreter to run your code, or monitoring an existing running Python process. So we do need some kind of metadata. But yes, if you have a Python version specified in pyproject.toml, we respect that, and if you have a virtualenv, we can see the Python version that was used to create that. And that's what we use to type-check your code. The default being discussed here is what we fall back on if that project metadata isn't available.