3 ms·
I'm not sure what the author was thinking when writing this framework but it appears that he/she forgot everything about writing sane code. Below is a list of t
by YorickPeterse 14y ago
I'm not sure what the author was thinking when writing this framework but it
appears that he/she forgot everything about writing sane code. Below is a list
of the things that stand out.
1. There's no sane directory structure, instead most of it is just dropped in a
single directory.
2. How am I supposed to install this? There's no package for it so it seems the
only way is to manually copy the repository. You'd think people would
actually use the Python package manager.
3. Shebangs are set to `#!C:\Python26\python.exe -u`. This is wrong on so many
levels.
4. The code is just...no. Take a look at `generate_controller.py`, if there's
anything that's not Pythonic code it's this.
5. A lot of the directory names are hardcoded all over the place, this means
that if you ever want to change some of the names (or re-organize them)
you'll have to go through all the files and modify them accordingly.
These are just a few of the items I find worth mentioning. The code in general
looks very amateuristic and I doubt it solves any problem that isn't already
solved by more well developed frameworks such as Flask, Django and so on.
- joshstrange 14y agoAlso the video was painfully long... I agree a package manager should be used. I stopped looking after those 2 issues and never even got a chance to dive into the, what looks to be bad, code.
- jlarocco 14y agoAnd it's not forward compatible at all. I know Python 2 or 3 is an ongoing debate, but there's no reason to be blatantly incompatible on a new project by using deprecated functionality like print statements instead of functions. Especially not on low hanging fruit like that.
- ninjin 14y agoWell, while you mention forward compatibility, there is also backwards compatibility. I am really a person that loves to move towards 3.x, but having a ton of users (some not technical enough to compile Python) with old Python installations (2.5.x or older) as default on their machines (CentOS for example is always an issue...) it is a double-edged sword since 2.6.0a2 is required to use Unicode literals and the print function [1]. I remember reading a long time ago that the fact that Python comes as default for many distributions may very well become a curse, I fear, that this may very well be true. [1]: http://docs.python.org/library/__future__.html http://docs.python.org/library/__future__.html