4 ms·
This looks like a nice approach to making wasi-libc faster. Could you submit these changes upstream?
by phickey 1y ago
This looks like a nice approach to making wasi-libc faster. Could you submit these changes upstream?
- ncruces 1y agoI'd like to be a little more sure that I'm not totally messing things up before doing that, but yes, eventually, that would be a nice outcome. I've also only really tested wazero. I can't know for sure that this is a straight improvement for other runtimes and architectures. For instance, the code delays using wasm_i8x16_bitmask as much as possible, because on Aarch64 it can be slower than not using SIMD at all, whereas it's plenty fast on x86-64.
- phickey 1y agoThe maintainers of wasi-libc are some of the best people to review this, and I don’t think it would be wasting their time to ask them to look at a PR.
- ncruces 1y agoA PR is a significant investment from me. I'd have to figure out where something like this is supposed to fit, how the build infra works, etc. One of the nice things about Go is how much that's a solved issue out of the box, compared to almost everything else; certainly compared to C. Pinging them in an issue: https://github.com/WebAssembly/wasi-libc/issues/580 https://github.com/WebAssembly/wasi-libc/issues/580