2 ms·
I'm not an expert on this corner of git, but a guess: trailer keys are not unique, that is Signed-off-by: Alice <alice@example.com> Signed-off-by: Bob <bob
by steveklabnik 2y ago
I'm not an expert on this corner of git, but a guess: trailer keys are not unique, that is
Signed-off-by: Alice <alice@example.com>
Signed-off-by: Bob <bob@example.com>
is totally fine, but
Change-id: wwyzlyyp
Change-id: sopnqzkx
is not.
I've also heard of issues with people copy/pasting commit messages and including bits of trailers they shouldn't have, I believe.
- bananapub 2y ago~I think it's more that not all existing git commands (rebase, am, cherry-pick?) preserve all headers.~ ignore, misread the above
- steveklabnik 2y agoThat's a downside of using headers, not a reason for using them. If upstream git changes to help this, it would involve having those preserve the headers. (though cherry-pick has good arguments of preserving vs generating a new one)
- bananapub 2y agoah, I'm sorry, I misread your comment (and should have mentioned the cherry-pick thing anyway).
- steveklabnik 2y agoIt’s all good!