4 ms·
Enjoyed the article. Am I out of touch or have the article linked to a PR of the rust-lang eco system that didn’t go through a CR, is this really the standard f
by null_deref 2y ago
Enjoyed the article.
Am I out of touch or have the article linked to a PR of the rust-lang eco system that didn’t go through a CR, is this really the standard for such a large language standard library?
- simonw 2y agoYou mean this one? https://github.com/rust-lang/bors/pull/251 https://github.com/rust-lang/bors/pull/251 If you look at https://github.com/rust-lang/bors https://github.com/rust-lang/bors it's not a standard library package, it's a tool to support the Rust development process. And the person who opened and landed that PR is the lead developer of that project. Skipping a code review from someone else feels OK to me for that.
- null_deref 2y agoThanks for the clarification, definitely makes sense
- shepmaster 2y agoAgree with simonw’s sibling comment. To add to it, I’m the primary maintainer of the Rust playground and basically self-review every single commit. The rust-lang/rust repository has higher scrutiny (in part driven by tools like bors, the subject of the article).
- null_deref 2y agoI am very sorry for casting doubt, the sibling comment makes a lot of sense.