3 ms·
A one-liner: sure. A ticket? No; ticket systems are transient and not always available. You shouldn't need to open an external system that may no longer exist i
by Cthulhu_ 2y ago
A one-liner: sure. A ticket? No; ticket systems are transient and not always available. You shouldn't need to open an external system that may no longer exist in 20 years time (for example) to get the full context.
Compare the Linux commit history, every commit has its full context and explanation and they do not rely on external systems.
- deleted 2y ago[deleted]
- dirkf 2y ago20? Try 5... I"m working on a repository that uses at least four different jira ticket number formats. All commits should have a jira reference but I think only the current format can still be looked up. And maybe the predecessor if you know what jira field to query. All the rest are lost in corporate limbo. Not that those tickets added much more context to the actual commit... So yeah, always write your commit messages as standalone as possible.
- yaris 2y agoOur ticket system survived almost 20 years and is useless anyway, because approximately half of the history consists of pairs like: commit 12345 ”fixed a bug, see ticket 54321” - ticket 54321 ”fixed by commit 12345”.
- drac89 2y agoI agree maybe not adding the ticket link is better if you know that the system might not be available in the future. You can not avoid it all the time but maybe It's better to use the PR description for that purpose.