2 ms·
I did something similar recently for deploying some Bevy examples to a webpage: https://github.com/victorb/dogoap/blob/3505cb42784381b696ce5a3f749b6c095ae320b6/
by diggan 2y ago
I did something similar recently for deploying some Bevy examples to a webpage: https://github.com/victorb/dogoap/blob/3505cb42784381b696ce5a3f749b6c095ae320b6/.github/workflows/wasm-examples.yml https://github.com/victorb/dogoap/blob/3505cb42784381b696ce5...
Probably not a problem unless you work with others or have a tendency to push commits fast/have a slow pipeline (building WASM from Rust is really slow), but it seems you're missing to limit the concurrency, which can lead to old commit being deployed over a newer commit, depending on which finishes first.
Also limiting it to your main/master branch makes sense in case you use branches, otherwise WIP branches might deploy over your "production" one :)
One final word of advice, try to do as little as possible in the .yml configuration itself (I see Simon is "emulating" the build process inside of the CI config), as testing changes becomes a huge hassle otherwise. Instead, extract it into a shell-script/Makefile/Justfile or something, then call that from your CI config, so you can also run the same code locally.