3 ms·
I know how to read, and that MR comment sounds 100% reasonable to me. Normally you'd take a comment like that, go "oh, okay let me do some more investigations"
by TheRealPomax 2y ago
I know how to read, and that MR comment sounds 100% reasonable to me. Normally you'd take a comment like that, go "oh, okay let me do some more investigations" and start a dialog instead of going "they rejected my MR on the first pass, they don't know what they're doing and their library is antiquated".
Where's the follow-up, or did you just walk away?
- TheRealPomax 2y agoBecause to be a clear: a reviewer comment is the start of the conversation, if you don't respond then the bad actor is you, not them. Ask them why they don't want to use math.h, ask them if there are dev documents that explain what can and can't be used, and why. If you don't, this failure is on you, not them.
- Ono-Sendai 2y agoA more reasonable reply would be something like, "wow, that's cool that you got a 4x speedup. A 4x speedup is certainly enough to justify using floating point maths. And the code is simpler too!"