3 ms·
> Similarly, we think the purpose of code review must obviously be for reviewing code until we look deeper and understand the sociological purposes of code revi
by JohnFen 2y ago
> Similarly, we think the purpose of code review must obviously be for reviewing code until we look deeper and understand the sociological purposes of code review.
The truth of this was made clear to me when everyone started doing asynchronous online "code reviews" where the reviewers are just looking at the code (in theory, anyway).
That alone eliminated the majority of the benefit of code reviews, where the author of the code walks through it and explains it in real time. It was amazing how many times I'd seen devs get partway into their explanation then stop when doing that gave them an important insight or revelation that otherwise would never have been surfaced.
- davely 2y agoOne thing I enjoy when working on a new feature is to schedule a team call for me to walk through the code, detailing the changes or improvements I've made, thought processes and overall just give better context into what the wall of text they are going to review is all about. Likewise, I enjoy when colleagues take the time to do the same with their own PRs. It's something I've tried to promote, but I think everyone is just in a default mode of ship-ship-ship, so people aren't eager to have another meeting to attend. (Ideally, we shouldn't be submitting PRs that are so huge, but sometimes this isn't always feasible.)