3 ms·

> When reviewing Go code This article reads as a parody of the worst sort of code review. This seems to be a person who sees themselves as little more than a r

> When reviewing Go code This article reads as a parody of the worst sort of code review. This seems to be a person who sees themselves as little more than a regex engine. Were I writing a go codebase in the UK, all spellings would be UK -- because of how absurd it would be to retrain the staff to split their brain on a trivial issue of this kind. Likewise plurals do not matter, -- double spacing in comment sentences? I cannot imagine comment whitespacing being on the radar of any person one would wish to have as a team mate.

jrockway 2y ago
Being consistent is the key. When you open up a codebase worked on by 50 people, it's nice when you can't tell who wrote it because of the spelling or whatever. Everyone on the team can see it, think "this looks like I wrote it", and work on it accordingly. That's a good thing.
Joker_vD 2y ago
> Were I writing a go codebase in the UK, all spellings would be UK. What about if you were in Australia? Germany? Poland? Bulgaria? China? > how absurd it would be to retrain the staff to split their brain on a trivial issue of this kind. I've seen this argument used to argue that all the spellings in source code should be US English, always and everywhere. In my opinion, this (being able to use the same argument to argue both for and against the same issue) invalidates the argument entirely.
- mjburgess 2y ago
  So, just to be clear, you think the right level of abstraction that codebase rules should operate at is, "the codebase should be accessible to programmers in every country across the world without modification" even when no such programmers operate on the codebase or are likely to ? Do you apply this rule uniformly, or just to spellings? The level of time-wasting here is off the charts. Write code to solve problems. If you have an international team, have international standards, if you do not -- it does not matter. If any of this changes, literally, apply a regex. OP is a blog article about rules for a code review -- as if the relevant part of the review is spelling ? Are we mad? Code review isnt to enforce these superficial standards -- these are regexes/flags in a build process. Code review is to ensure the code solves the problem under functional/non-functional constraints, in a manner which is easy to understand, communicates intention, etc. Anyone talking about whether something is pluralised in a code review is a person who should be no where near any such process. They are clearly pathologically incapable of prioritisation or completely uninterested in review.

jrockway 2y ago

Being consistent is the key. When you open up a codebase worked on by 50 people, it's nice when you can't tell who wrote it because of the spelling or whatever. Everyone on the team can see it, think "this looks like I wrote it", and work on it accordingly. That's a good thing.

Joker_vD 2y ago

> Were I writing a go codebase in the UK, all spellings would be UK. What about if you were in Australia? Germany? Poland? Bulgaria? China? > how absurd it would be to retrain the staff to split their brain on a trivial issue of this kind. I've seen this argument used to argue that all the spellings in source code should be US English, always and everywhere. In my opinion, this (being able to use the same argument to argue both for and against the same issue) invalidates the argument entirely.

mjburgess 2y ago
So, just to be clear, you think the right level of abstraction that codebase rules should operate at is, "the codebase should be accessible to programmers in every country across the world without modification" even when no such programmers operate on the codebase or are likely to ? Do you apply this rule uniformly, or just to spellings? The level of time-wasting here is off the charts. Write code to solve problems. If you have an international team, have international standards, if you do not -- it does not matter. If any of this changes, literally, apply a regex. OP is a blog article about rules for a code review -- as if the relevant part of the review is spelling ? Are we mad? Code review isnt to enforce these superficial standards -- these are regexes/flags in a build process. Code review is to ensure the code solves the problem under functional/non-functional constraints, in a manner which is easy to understand, communicates intention, etc. Anyone talking about whether something is pluralised in a code review is a person who should be no where near any such process. They are clearly pathologically incapable of prioritisation or completely uninterested in review.