5 ms·
> GitHub PRs are Markdown documents, and some organizations have specific templates with checklists for all reviewers to complete. Enforcing these often require
by verdverm 2y ago
> GitHub PRs are Markdown documents, and some organizations have specific templates with checklists for all reviewers to complete. Enforcing these often requires ugly regexes that are a pain to write and worse to debug
This is because GitHub is not building the features we need, instead they are putting their energy towards the AI land grab. Bitbucket, by contrast, has a feature where you can block PRs using a checkbox list outside of the description box. There are better ways to solve this first example from OP readme. Cool project, I write mainly MDX these days, would be cool to see support for that dialect
- yshavit 2y agoThe Markdown parsing library I'm using supports MDX, so it shouldn't be too difficult to come up with syntax for those components. I haven't done that yet, but mostly because I didn't want to go down that path until I knew there was interest and had a concrete use case or two to inform the query syntax. If you want to open an enhancement request issue, I'm happy to take a look (PRs also welcome, but not required). If you're not on GitHub, let me know and we can figure out some other way to get the request tracked. Thanks for taking a look at the project!
- codelion 2y agoit's a shame when core feature development seems to lag. i've also been working w/ MDX lately & agree that support would be a great addition.
- echelon 2y ago> This is because GitHub is not building the features we need, instead they are putting their energy towards the AI land grab. You throw the ball to where it's going. Gitlab might be delivering more value in the short term, but if things wind up looking significantly different in ten years, they might be in for a world of hurt. Innovator's dilemma is real. It's a danger to ignore the tectonic changes happening. It's also incredibly risky to lean fully in, because we're not sure where the value accrues or which systems are the most important to build. It doesn't seem like foundation models are it. It's smart to build basic scaffolding, let the first movers make all the expensive mistakes, then integrate the winning approaches into your platform. That requires a lot of energy though.
- mtndew4brkfst 2y ago> That requires a lot of energy though. So do the plagiarism machines!
- bradgessler 2y agoNot only is GitHub focused on AI, but they’re also making their UI slower and jankier by rewriting it in React. I feel like a “Linear for GitHub” is due.
- nicce 2y agoIs it true that it is React’s fault? Is there any other replacement for heavy user interaction, that is clearly more performative? You cannot do that on server side.
- tomcam 2y ago> Is there any other replacement for heavy user interaction, that is clearly more performative? Well-written React?
- deleted 2y ago[deleted]
- nicce 2y agoAfter reading a bunch of stuff as result of this, I think you are the most correct. Difference in performance on different frameworks seems to be more like philosophical rather than practical. It is enough that your website has just a couple of images, comparison of the "shipping size" of the runtime bundling becomes rather meaningless. It is the same for initial latency for showing the rendered content. These frameworks were designed for heavy sites, and their "base speed" becomes irrelevant. If you understand how do they work and use them correctly, there shouldn't be that much difference. Assuming, that we use JavaScript on client-side in the end.
- jkmcf 2y agoHow many well-written code bases have you seen? React is a PITA to learn, and even the easiest frameworks encounter devs who jump right in and commit shot code to deliver "value" right away, only for that code to live on forever haunting the devs left with mess after the founder coders move on.
- 2y ago
- hamandcheese 2y agoGitHub was ignoring users needs long before the AI craze.
- jvanderbot 2y agoIt's hard to remember, but as soon as gitlab showed up, GitHub went from a "maybe someday if I make it" site to a "let's just use GitHub for everything" site. Prior to gitlab ratcheting up the usability, features, and cost effectiveness, I preferred hosted git for 99% of use cases.
- cmddds 2y agoI just started using git, can you give me some advice?
- arminiusreturns 2y agoUse it everyday, preferable with a porcelain such as magit in emacs. Alias commands help. Run your own git server instead of using one of the big names. Use git hooks. (https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks) When starting out, looking at visuals of how git works can help a lot I've found when training others. (https://www.junosnotes.com/wp-content/uploads/2021/07/basic-git-commands-1024x576.png https://www.junosnotes.com/wp-content/uploads/2021/07/basic-...)
- tempaccount420 2y agoIs that why Gitlab doesn't innovate anymore? No point if GitHub just steals the features?
- kqr 2y ago> Bitbucket, by contrast, has a feature where you can block PRs using a checkbox list outside of the description box I'm not sure this is better. I like the idea of the full context of the PR being available in a small set of relatively standardised fields. Smaller, non-semantic sets are easier to standardise.
- verdverm 2y agoI'm not sure how having a list of remaining tasks that can be added to adhoc and block PRs from merging is not better than check boxes in markdown description box that are little more than aesthetic... It has saved us from self induced pain and is a great coordination point
- bastardoperator 2y agoOr maybe GitHub built these features over 10 years ago and millions upon millions of people use them daily without issue. You can literally have any semblance of what you're describing with a PR check, and that feature is also pretty old. The API is right there, you just have to use it.