3 ms·
Good point, I should've used direct initialization in this example. struct A { int x; A(A *a) { if (a) a->x = 42;} }; struct B { A a1;
by drysine 2y ago
Good point, I should've used direct initialization in this example.
struct A {
int x;
A(A *a) { if (a) a->x = 42;}
};
struct B {
A a1;
A a2;
};
void f()
{
B b{.a1{nullptr}, .a2{&b.a1} };
}
This code is valid.
Now if I change the struct definition to
struct B {
A a2;
A a1;
};
it will become UB. Luckily it won't compile because of the difference between the order of declaration and the order of designated initializers.
The alternative way is to always initialize the sub-objects in the order of designated initializers (what do we do if not all initializers are provided?), but this would mean that the order of constructor calls wouldn't match the (reversed) order of destructor calls. Or we would need to select the destructor dynamically based on the way the object was initialized.
https://godbolt.org/z/MPoqEhTvf https://godbolt.org/z/MPoqEhTvf
- badmintonbaseba 2y agoMy gripe was not the form of initialization of the elements, but forming `b.a1` before `b`'s lifetime has started. It hasn't started before all of the elements are initialized.
- drysine 2y agoBut do we need the lifetime of b to be started? Isn't it enough that a1's lifetime is started? Taking of address of a1 happens after that. [0] Upd: There is an interesting sentence in [class.cdtor] but I don't think it applies here because B has no constructors: "For an object with a non-trivial constructor, referring to any non-static member or base class of the object before the constructor begins execution results in undefined behavior."[1] [0] https://eel.is/c++draft/dcl.init.aggr#7 https://eel.is/c++draft/dcl.init.aggr#7 [1] https://eel.is/c++draft/class.cdtor#1 https://eel.is/c++draft/class.cdtor#1