4 ms·

How do you do code reviews with this model?

• roncohen 2y ago
  It’s in the post :) > In practice, many teams will use a pull request-based workflow because the tests could be too complicated to run locally or need to facilitate code reviews. For trunk-based development to fulfill its promise, it’s imperative that pull requests are kept small and that the team is committed to reviewing them quickly.
  • sebazzz 2y ago
    Then it is not trunk-based, it is still PR based. I would also wonder how bigger features would get developed, without littering it across multiple pull requests and feature flags to make sure the code still compiles.