6 ms·

Only somewhat related, but I'd pay decent money to have access to the whole Piper/CitC/Critique/Code Search stack. As much as I've tried to like it, I just don'

Only somewhat related, but I'd pay decent money to have access to the whole Piper/CitC/Critique/Code Search stack. As much as I've tried to like it, I just don't really like Github's code review tool.

tristanb 2y ago
Shameless plug, but we built http://CodePeer.com http://CodePeer.com - to bring Critique like features to everyone else. Take it for a spin if you like!
- aaomidi 2y ago
  How does this handle force pushes and stacked PRs?
  - tristanb 2y ago
    Should be pretty seamless. We may make stacked PRs more of a first class experience in the future.
mtlynch 2y ago
Former Googler. I also miss Critique/Gerrit. I've tried a bunch of alternatives, and I like CodeApprove: https://codeapprove.com/ https://codeapprove.com/ It's great if you have a team that does code reviews. It works less well for reviewing contributions from external contributors on an open-source project,a as the contributor likely just wants to get their PR merged and doesn't want to learn a special reviewing tool. No affiliation, just a happy customer.
- racl101 2y ago
  Do you know if this works with Azure DevOps? I hate their UI. At this point I'd love to use Github. But for some reason the higher ups want us to be on Azure DevOps.
- tantalor 2y ago
  "lookup table of similar technology and services to help ex-googlers survive the real world" https://github.com/jhuangtw/xg2xg https://github.com/jhuangtw/xg2xg
awkward 2y ago
Github's code review tool is uniquely bad. Notably it presents every comment as blocking and requiring sign off - even a "Glad someone cleaned this up! <thumbs up emoji>" needs clearing before merge. It also has some UX snafus that cause reviewers to write a number of comments and then forget to publish any of them, leading to a lot of interactions along the lines of "I thought you were going to review my PR?" "I already did?"
- plorkyeran 2y ago
  Requiring every comment to be resolved is not a standard part of GitHub’s code review system. That is something which your organization has gone out of its way to require.
  - awkward 2y ago
    This has been consistent across four organizations including one I participated in setting up. They don't seem to have gone far out of their way.
- etothet 2y ago
  Overall, I personally find the experience better than Gitlab's merge request UI/UX.
- catlover76 2y ago
  [dead]
codeapprove 2y ago
Shameless plug but since you asked ... CodeApprove (https://codeapprove.com https://codeapprove.com) is probably the closest thing you can get to Critique on GitHub. It doesn't help with the Piper/CitC/Code Search parts though, and I agree those were excellent.
- aaomidi 2y ago
  How does this handle force pushes and stacked PRs?

tristanb 2y ago

Shameless plug, but we built http://CodePeer.com http://CodePeer.com - to bring Critique like features to everyone else. Take it for a spin if you like!

aaomidi 2y ago
How does this handle force pushes and stacked PRs?
- tristanb 2y ago
  Should be pretty seamless. We may make stacked PRs more of a first class experience in the future.

mtlynch 2y ago

Former Googler. I also miss Critique/Gerrit. I've tried a bunch of alternatives, and I like CodeApprove: https://codeapprove.com/ https://codeapprove.com/ It's great if you have a team that does code reviews. It works less well for reviewing contributions from external contributors on an open-source project,a as the contributor likely just wants to get their PR merged and doesn't want to learn a special reviewing tool. No affiliation, just a happy customer.

racl101 2y ago
Do you know if this works with Azure DevOps? I hate their UI. At this point I'd love to use Github. But for some reason the higher ups want us to be on Azure DevOps.
tantalor 2y ago
"lookup table of similar technology and services to help ex-googlers survive the real world" https://github.com/jhuangtw/xg2xg https://github.com/jhuangtw/xg2xg

awkward 2y ago

Github's code review tool is uniquely bad. Notably it presents every comment as blocking and requiring sign off - even a "Glad someone cleaned this up! <thumbs up emoji>" needs clearing before merge. It also has some UX snafus that cause reviewers to write a number of comments and then forget to publish any of them, leading to a lot of interactions along the lines of "I thought you were going to review my PR?" "I already did?"

plorkyeran 2y ago
Requiring every comment to be resolved is not a standard part of GitHub’s code review system. That is something which your organization has gone out of its way to require.
- awkward 2y ago
  This has been consistent across four organizations including one I participated in setting up. They don't seem to have gone far out of their way.
etothet 2y ago
Overall, I personally find the experience better than Gitlab's merge request UI/UX.
catlover76 2y ago
[dead]

codeapprove 2y ago

Shameless plug but since you asked ... CodeApprove (https://codeapprove.com https://codeapprove.com) is probably the closest thing you can get to Critique on GitHub. It doesn't help with the Piper/CitC/Code Search parts though, and I agree those were excellent.

aaomidi 2y ago
How does this handle force pushes and stacked PRs?