5 ms·

If you look at the commit history and contributors, it's mostly him.

croemer 2y ago
I'd take commit numbers with a grain of salt. Also, I wouldn't call half the commits _mostly_ at all: https://github.com/JDKaim/HuskySwap/graphs/contributors?from=2024-07-29&to=2025-01-09&type=c https://github.com/JDKaim/HuskySwap/graphs/contributors?from... By that metric, he did half the work. But it still means he completely disregards the other half.
- prophesi 2y ago
  56 commits, +273,244, -7,270 LOC vs 46 commits, +478, -94 LOC I think it's safe to say it was mostly him.
  - croemer 2y ago
    Don't get fooled by LOCs. Out of the 273k LOC added, all but 20k, that is 253k are just from the boilerplate auto-generated copy/paste initialization code: https://github.com/JDKaim/HuskySwap/commit/e9f0df0d5a221b3c7892c997d089989b9c3e35c7#diff-e1f4f87cc9d43f016d3a857f1db0c6df63bcb095b8992743abaa6a53411be3b0 https://github.com/JDKaim/HuskySwap/commit/e9f0df0d5a221b3c7... Sure he probably did most of the coding, but it's still weird to talk all about I and not mention the other 5 in a single word when they _did_ contribute. Maybe they did testing or other things that are not reflected in LOC, e.g. presentations etc.
    - cdurth 2y ago
      Not just random biloilerplate/framework code either. A framework his dad created. So with this logic his dad did the majority of the project.
      - croemer 2y ago
        His dad? How do you know? One doesn't count React in the LOC so why should one count a boilerplate template? As I said, LOC are not a good proxy. Update: I see, LightNap is the work of Ed Kaim, surname checks out. https://github.com/SharpLogic/LightNap https://github.com/SharpLogic/LightNap
    - prophesi 2y ago
      I see the point of contention now. Though I don't think we're being fooled by LOC's. You can check the commits from the other contributors, and it's all documentation / adding line breaks. It's unfortunately common at universities for CS projects to be spearheaded by one gungho student with the others only tidying things up for in-class presentations.
      - croemer 2y ago
        It's also not 56 vs 46 commits but 56 vs 63. 46 is the second biggest committee but there are 17 more commits from the other 4 and my initial point was that it was odd for him to not mention the other contributors at all. Even if he did the major part, I would never say I created something if it was a team effort. He lead.

I'd take commit numbers with a grain of salt. Also, I wouldn't call half the commits _mostly_ at all: https://github.com/JDKaim/HuskySwap/graphs/contributors?from=2024-07-29&to=2025-01-09&type=c https://github.com/JDKaim/HuskySwap/graphs/contributors?from... By that metric, he did half the work. But it still means he completely disregards the other half.

prophesi 2y ago
56 commits, +273,244, -7,270 LOC vs 46 commits, +478, -94 LOC I think it's safe to say it was mostly him.
- croemer 2y ago
  Don't get fooled by LOCs. Out of the 273k LOC added, all but 20k, that is 253k are just from the boilerplate auto-generated copy/paste initialization code: https://github.com/JDKaim/HuskySwap/commit/e9f0df0d5a221b3c7892c997d089989b9c3e35c7#diff-e1f4f87cc9d43f016d3a857f1db0c6df63bcb095b8992743abaa6a53411be3b0 https://github.com/JDKaim/HuskySwap/commit/e9f0df0d5a221b3c7... Sure he probably did most of the coding, but it's still weird to talk all about I and not mention the other 5 in a single word when they _did_ contribute. Maybe they did testing or other things that are not reflected in LOC, e.g. presentations etc.
  - cdurth 2y ago
    Not just random biloilerplate/framework code either. A framework his dad created. So with this logic his dad did the majority of the project.
    - croemer 2y ago
      His dad? How do you know? One doesn't count React in the LOC so why should one count a boilerplate template? As I said, LOC are not a good proxy. Update: I see, LightNap is the work of Ed Kaim, surname checks out. https://github.com/SharpLogic/LightNap https://github.com/SharpLogic/LightNap
  - prophesi 2y ago
    I see the point of contention now. Though I don't think we're being fooled by LOC's. You can check the commits from the other contributors, and it's all documentation / adding line breaks. It's unfortunately common at universities for CS projects to be spearheaded by one gungho student with the others only tidying things up for in-class presentations.
    - croemer 2y ago
      It's also not 56 vs 46 commits but 56 vs 63. 46 is the second biggest committee but there are 17 more commits from the other 4 and my initial point was that it was odd for him to not mention the other contributors at all. Even if he did the major part, I would never say I created something if it was a team effort. He lead.