4 ms·
What was the established code style (...if any) in that project? Anyway it doesn't sound like that was a very mature project or developers, not when the review
by Cthulhu_ 2y ago
What was the established code style (...if any) in that project?
Anyway it doesn't sound like that was a very mature project or developers, not when the reviewer decide to just edit code instead of provide a review.
- ge96 2y agothe old/existing code was all underscore, they wanted to use camelcase instead. it's a dumb thing to be argue about I know but it made the code review harder when instead of 10s of line diffs there's almost a hundred granted easy to see just changing casing
- willseth 2y agoI just insist that style only changes go in a separate commit.
- JTyQZSnP3cQGa8B 2y agoAnd when it impacts a lot of files, it can break the compiler or introduce bugs. It MUST go in its own PR/MR.