3 ms·
It would still break if you need to modify that output in any way. Need to add a class for styling? The snapshot breaks. Need to add a new hx-attribute? The sna
by Hasu 2y ago
It would still break if you need to modify that output in any way. Need to add a class for styling? The snapshot breaks. Need to add a new hx-attribute? The snapshot breaks. It's not tied to the logic, it's tied to whatever markup you output. You've reduced the surface area of the problem, but not eliminated it.
> If you have snapshots that are breaking for irrelevant changes, then by definition those changes don't need to be snapshotted, do they?
You're so close to getting it.
- yawaramin 2y ago> Need to add a class for styling? How often? All the time? Or relatively rarely? For most projects, it's the latter. We are not constantly churning the styling. > Need to add a new hx-attribute? The snapshot breaks. It's not tied to the logic An `hx-` attribute is logic. That's the point of htmx. > You've reduced the surface area of the problem, but not eliminated it. That's a risk of any kind of unit test. You can always have false positives. > You're so close to getting it. That tests should be fixed until they're robust? I'm not a fan of the learned helplessness of the 'We couldn't figure out how to do XYZ, therefore XYZ is a bad idea' approach.