3 ms·

Only if they actually communicate what they’ve learned from it and what changes they’re making to prevent such mistakes in the future / catch them before releas

Only if they actually communicate what they’ve learned from it and what changes they’re making to prevent such mistakes in the future / catch them before release. Until then you can assume that they’ll keep making similar classes of mistakes.

jdwithit 2y ago
I mean the patch notes for this issue literally do this, so they seem to be off to a good start.
- vlovich123 2y ago
  No, all the patch notes say is “I learned from my mistake and ripped out all the logging code”. That’s not actually a postmortem of a list of process changes. Nothing about how WIP changes made it through into a code release nor in how such mistakes will be prevented in the future. There’s a much richer discussion of options in this thread of things people do to prevent things like this. For example, reading environment variables from a file that’s gitignored so that you never accidentally commit something and you don’t need to mutate code to do a config change. He may indeed have learned from his mistakes, but I’m pointing out the flaw of assuming every mistake was treated as a learning opportunity, especially when no real evidence exists to suggest that.
soraminazuki 2y ago
What did George ever do to you that warrants this level of contempt and condescension? Am I missing something, because there are so many activists like you having an inexplicable vendetta against iTerm2 all over this thread. This is sad because iTerm2 is one of the best terminal emulators out there. It's the first terminal emulator that popularized shell integration. Newer terminal emulators are still catching up, a decade later. tmux integration is another popular feature that's still unique to iTerm2. George has been working tirelessly on iTerm2 pretty much solo for 15 years [1]. To this day, he continuously brings new improvements to the terminal experience that keeps being copied by other terminal emulators. Developers benefit from his work, iTerm2 users and non-users alike. We should be expressing our gratitude instead of doing whatever people are doing in this thread. George found this security issue the day after New Year's day and immediately released a fix [2]. That's commitment. And while the effects of this bug can be severe, most people wouldn't have triggered the bug. > 1. Either: > a) You used the it2ssh command, or > b) In Settings > Profiles > General, the > Command popup menu was set to "SSH" (not > "Login Shell", "Command", or "Custom > Command") AND "SSH Integration" was checked > in the SSH configuration dialog. That dialog > is shown when you click the Configure button > next to the ssh arguments field in Settings. It's almost as if some people are jumping at any chance of retribution, justified or not. This all sure intensified after iTerm2 at one point introduced an AI-related feature into the default build that one can just safely forget exists by not actively enabling and engaging with it. Some in the Mastodon community even went as far as openly fantasizing about inflicting violence on the poor dev [3]. I just can't understand the morality of some of the people you see online. [1]: https://github.com/gnachman/iTerm2/graphs/contributors https://github.com/gnachman/iTerm2/graphs/contributors [2]: https://github.com/gnachman/iTerm2/commits/master/?since=2025-01-01&until=2025-01-03 https://github.com/gnachman/iTerm2/commits/master/?since=202... [3]: https://web.archive.org/web/20240613170001/https://archive.is/BDmKU https://web.archive.org/web/20240613170001/https://archive.i...
- rougka 2y ago
  The terminal is the last bastion of the "good old times" for many people. that's why a terminal aiming at modernizing the experience is so triggering
  - soraminazuki 2y ago
    iTerm2 doesn't interfere with people wanting the same old experience and you don't even have to use it either. Being "triggered" by a free and open source passion project that has helped countless number of developers around the world is beyond absurd. "Ungrateful" doesn't even begin to describe it.
    - rougka 2y ago
      Don't get me wrong, I like it. But there's a fake nostalgia around terminals lately (nvim, oh-my-zsh, etc) and it seems emotional
      - soraminazuki 2y ago
        People have always been emotional about their choice of software, I guess. But people are treating George, who has shown nothing but good faith this past 15 years of iTerm2 development, like the product manager of Windows Recall. That's a whole new level of emotional response which I don't understand where it's even coming from.
- vlovich123 2y ago
  There is absolutely 0 condescension in my comment. All I highlighted is the flaw in the argument that a mistake made is a lesson learned. Indeed, there’s no indication the root cause of the lesson leading to this situation has indeed been learned. You seem to be triggered by a perceived critical comment of a piece of software you’ve developed an emotional attachment to. I have not attacked anyone associated with the iterm2 project nor have I questioned his talent in creating a popular project or his commitment to it. Lumping me in with toxic people you encountered on social networks is completely uncalled for and I’ve never called for violence against anyone.

jdwithit 2y ago

I mean the patch notes for this issue literally do this, so they seem to be off to a good start.

vlovich123 2y ago
No, all the patch notes say is “I learned from my mistake and ripped out all the logging code”. That’s not actually a postmortem of a list of process changes. Nothing about how WIP changes made it through into a code release nor in how such mistakes will be prevented in the future. There’s a much richer discussion of options in this thread of things people do to prevent things like this. For example, reading environment variables from a file that’s gitignored so that you never accidentally commit something and you don’t need to mutate code to do a config change. He may indeed have learned from his mistakes, but I’m pointing out the flaw of assuming every mistake was treated as a learning opportunity, especially when no real evidence exists to suggest that.

soraminazuki 2y ago

What did George ever do to you that warrants this level of contempt and condescension? Am I missing something, because there are so many activists like you having an inexplicable vendetta against iTerm2 all over this thread. This is sad because iTerm2 is one of the best terminal emulators out there. It's the first terminal emulator that popularized shell integration. Newer terminal emulators are still catching up, a decade later. tmux integration is another popular feature that's still unique to iTerm2. George has been working tirelessly on iTerm2 pretty much solo for 15 years [1]. To this day, he continuously brings new improvements to the terminal experience that keeps being copied by other terminal emulators. Developers benefit from his work, iTerm2 users and non-users alike. We should be expressing our gratitude instead of doing whatever people are doing in this thread. George found this security issue the day after New Year's day and immediately released a fix [2]. That's commitment. And while the effects of this bug can be severe, most people wouldn't have triggered the bug. > 1. Either: > a) You used the it2ssh command, or > b) In Settings > Profiles > General, the > Command popup menu was set to "SSH" (not > "Login Shell", "Command", or "Custom > Command") AND "SSH Integration" was checked > in the SSH configuration dialog. That dialog > is shown when you click the Configure button > next to the ssh arguments field in Settings. It's almost as if some people are jumping at any chance of retribution, justified or not. This all sure intensified after iTerm2 at one point introduced an AI-related feature into the default build that one can just safely forget exists by not actively enabling and engaging with it. Some in the Mastodon community even went as far as openly fantasizing about inflicting violence on the poor dev [3]. I just can't understand the morality of some of the people you see online. [1]: https://github.com/gnachman/iTerm2/graphs/contributors https://github.com/gnachman/iTerm2/graphs/contributors [2]: https://github.com/gnachman/iTerm2/commits/master/?since=2025-01-01&until=2025-01-03 https://github.com/gnachman/iTerm2/commits/master/?since=202... [3]: https://web.archive.org/web/20240613170001/https://archive.is/BDmKU https://web.archive.org/web/20240613170001/https://archive.i...

rougka 2y ago
The terminal is the last bastion of the "good old times" for many people. that's why a terminal aiming at modernizing the experience is so triggering
- soraminazuki 2y ago
  iTerm2 doesn't interfere with people wanting the same old experience and you don't even have to use it either. Being "triggered" by a free and open source passion project that has helped countless number of developers around the world is beyond absurd. "Ungrateful" doesn't even begin to describe it.
  - rougka 2y ago
    Don't get me wrong, I like it. But there's a fake nostalgia around terminals lately (nvim, oh-my-zsh, etc) and it seems emotional
    - soraminazuki 2y ago
      People have always been emotional about their choice of software, I guess. But people are treating George, who has shown nothing but good faith this past 15 years of iTerm2 development, like the product manager of Windows Recall. That's a whole new level of emotional response which I don't understand where it's even coming from.
vlovich123 2y ago
There is absolutely 0 condescension in my comment. All I highlighted is the flaw in the argument that a mistake made is a lesson learned. Indeed, there’s no indication the root cause of the lesson leading to this situation has indeed been learned. You seem to be triggered by a perceived critical comment of a piece of software you’ve developed an emotional attachment to. I have not attacked anyone associated with the iterm2 project nor have I questioned his talent in creating a popular project or his commitment to it. Lumping me in with toxic people you encountered on social networks is completely uncalled for and I’ve never called for violence against anyone.