4 ms·

That's not unreasonable code in itself, it's writing to the file only if verbose mode is enabled. This is the commit which disabled verbose mode, just before t

by mort96 2y ago

That's not unreasonable code in itself, it's writing to the file only if verbose mode is enabled. This is the commit which disabled verbose mode, just before the code which removed verbose framer logging entirely: https://github.com/gnachman/iTerm2/commit/014ba7ec40fc790f650ad73ae7ff9ca7a6964aed https://github.com/gnachman/iTerm2/commit/014ba7ec40fc790f65... This is the commit which enabled VERBOSE mode: https://github.com/gnachman/iTerm2/commit/5db0f74bf647f6d53ea33d2491f9b8e4972c2e03 https://github.com/gnachman/iTerm2/commit/5db0f74bf647f6d53e... (from Jul 3, 2024) That is probably just from having set VERBOSE=1 while implementing or debugging something and forgetting to revert it to VERBOSE=0 before committing.

lupire 2y ago
This is why all "temporary" settings go in .gitignored files or equivalent, or on no-merge testing branches, and we have test on the release branch that asserts for each config value that it is set to a safe value, and we have a test that reflectively asserts that every config key has a value assertion test.
- hnlmorg 2y ago
  Or non-default compile time flags. That’s how I handle verbose debugging in my terminal emulator.
CGamesPlay 2y ago
This variable might have been better named LOG_ALL_STDIO_TO_TMP. Would have made it more obvious during self-review that it shouldn't be shipped.
- bobbylarrybobby 2y ago
  Or even better: # TODO: set back to 0 This appears as a warning in my editor, and of course is greppable
  - darknavi 2y ago
    Don't mind me with 100s of // TODO in my codebases.
    - bobbylarrybobby 2y ago
      Then # HACK: or # FIXME: or # DO_NOT_SHIP... anything greppable and distinct enough to error in CI
      - pandemic_region 2y ago
        or having a commit hook that fails if the code contains such string
nothrabannosir 2y ago
This happened to me so often that I made a git pre-commit hook to catch it: https://github.com/nobssoftware/nocommit https://github.com/nobssoftware/nocommit for the word NOCOMMIT Includes a GitHub CI action to prevent merging it in to master It has caught so many of these mistakes for me…
- huskymybeloved 2y ago
  I only heard of pre-commit hooks like 20 times in the wild and I really want to emphasize how badly that number should be 10x larger. Got a team completely unaware they existed once.
  - cdeevgtg 2y ago
    They are just not convenient to use since they are per repo and not shared via clone
    - virgoerns 2y ago
      They can be configured globally with core.hooksPath or init.templatedir git config options.
  - NekkoDroid 2y ago
    I really do wish that git itself would like check for a `.githooks` directory and prompt if it should set `core.hooksPath` to that path (probably would need to notify on pull when any files in it changed for security reasons) I would also love if it detected a `.gitmessage` for message the message template without needing to set it up for each repo, but that is a different matter.

by mort96 2y ago

lupire 2y ago

This is why all "temporary" settings go in .gitignored files or equivalent, or on no-merge testing branches, and we have test on the release branch that asserts for each config value that it is set to a safe value, and we have a test that reflectively asserts that every config key has a value assertion test.

hnlmorg 2y ago
Or non-default compile time flags. That’s how I handle verbose debugging in my terminal emulator.

CGamesPlay 2y ago

This variable might have been better named LOG_ALL_STDIO_TO_TMP. Would have made it more obvious during self-review that it shouldn't be shipped.

bobbylarrybobby 2y ago
Or even better: # TODO: set back to 0 This appears as a warning in my editor, and of course is greppable
- darknavi 2y ago
  Don't mind me with 100s of // TODO in my codebases.
  - bobbylarrybobby 2y ago
    Then # HACK: or # FIXME: or # DO_NOT_SHIP... anything greppable and distinct enough to error in CI
    - pandemic_region 2y ago
      or having a commit hook that fails if the code contains such string

nothrabannosir 2y ago

This happened to me so often that I made a git pre-commit hook to catch it: https://github.com/nobssoftware/nocommit https://github.com/nobssoftware/nocommit for the word NOCOMMIT Includes a GitHub CI action to prevent merging it in to master It has caught so many of these mistakes for me…

huskymybeloved 2y ago
I only heard of pre-commit hooks like 20 times in the wild and I really want to emphasize how badly that number should be 10x larger. Got a team completely unaware they existed once.
- cdeevgtg 2y ago
  They are just not convenient to use since they are per repo and not shared via clone
  - virgoerns 2y ago
    They can be configured globally with core.hooksPath or init.templatedir git config options.
- NekkoDroid 2y ago
  I really do wish that git itself would like check for a `.githooks` directory and prompt if it should set `core.hooksPath` to that path (probably would need to notify on pull when any files in it changed for security reasons) I would also love if it detected a `.gitmessage` for message the message template without needing to set it up for each repo, but that is a different matter.