4 ms·
> Read every line of your own PRs before you submit them I do. Everyone should. I’m also a fan of small focused PRs. > If you worked with me it would be worth
by sarchertech 2y ago
> Read every line of your own PRs before you submit them
I do. Everyone should. I’m also a fan of small focused PRs.
> If you worked with me it would be worth doing mandatory PRs.
Given the number of PRs I’ve merged and the number of mistakes that reviewers have caught, I think it’s very unlikely that you’d catch those things at a frequency high enough to justify the cost.
I’m not doubting that you can find those things or that you have found them. But again I have merged thousands of PRs with hundreds of reviewers across numerous companies in multiple languages and I have never had a reviewer catch a major bug.
That’s a large enough sample size with no effect at all, that I’m going to need hard evidence to make me believe that people are finding these things at a high enough rate to justify the cost.