3 ms·

> Involve junior developers in architecture reviews. They will help you to identify the mentally demanding areas. This. And also, a mantra of my own: Listen c

> Involve junior developers in architecture reviews. They will help you to identify the mentally demanding areas. This. And also, a mantra of my own: Listen carefully to any newcomer in the team/company in first 1-3 weeks, until s/he gets accustomed (and/or stop paying attention to somewhat uneasy stuff). They will tell you all things that are, if not wrong, at least weird.

tantalor 2y ago
Junior developers probably won't say anything, because they are used to not understanding code, and they are not going to second guess the more-experienced author.
- jstummbillig 2y ago
  It's definitely on the senior to prompt the junior appropriately. But when you do, they will.
ben_w 2y ago
Aye, but the joiners may need prompting as well as getting listened to. In each place where I've seen something wildly wrong, the problem has been clear in the first few weeks — sometimes even in the first few days* — but I always start with the assumption that if I disagree with someone who has been at it for years, they've probably got good reasons for the stuff that surprises me. Unfortunately I'm not very convincing: when I do finally feel confident enough to raise stuff, quite often they do indeed have reasons… bad reasons that ultimately prove to be fatal or near-fatal flaws to their business plans, but the issues only seldom get fixed once I raise them. * one case where the problem was visible in the interview, but I was too young and naive so I disregarded what I witnessed, and I regretted it.
epolanski 2y ago
I second this, but one should also be extremely wary of newcomers feedback and try to understand their nature. Some people are extremely resistant to new ideas, some might be simply lazy, some can't be bothered to read documentations, etc. Spotting the real person behind the feedback is crucial and often those people need to be fired fast. I myself tend to be lazy when it comes to learn new stuff/patterns, especially when I am in the middle of having to progress a project so my own feedback may be more of a frustration for my inability to progress due to having to understand first a, b, c and d which may take considerable time and pain for something I can do in an old way in few minutes.

tantalor 2y ago

Junior developers probably won't say anything, because they are used to not understanding code, and they are not going to second guess the more-experienced author.

jstummbillig 2y ago
It's definitely on the senior to prompt the junior appropriately. But when you do, they will.

ben_w 2y ago

Aye, but the joiners may need prompting as well as getting listened to. In each place where I've seen something wildly wrong, the problem has been clear in the first few weeks — sometimes even in the first few days* — but I always start with the assumption that if I disagree with someone who has been at it for years, they've probably got good reasons for the stuff that surprises me. Unfortunately I'm not very convincing: when I do finally feel confident enough to raise stuff, quite often they do indeed have reasons… bad reasons that ultimately prove to be fatal or near-fatal flaws to their business plans, but the issues only seldom get fixed once I raise them. * one case where the problem was visible in the interview, but I was too young and naive so I disregarded what I witnessed, and I regretted it.

epolanski 2y ago

I second this, but one should also be extremely wary of newcomers feedback and try to understand their nature. Some people are extremely resistant to new ideas, some might be simply lazy, some can't be bothered to read documentations, etc. Spotting the real person behind the feedback is crucial and often those people need to be fired fast. I myself tend to be lazy when it comes to learn new stuff/patterns, especially when I am in the middle of having to progress a project so my own feedback may be more of a frustration for my inability to progress due to having to understand first a, b, c and d which may take considerable time and pain for something I can do in an old way in few minutes.