4 ms·
The code is in the code base. Presumably, it still gets run. It doesn't make a difference if new code doesn't look like that.
by parineum 2y ago
The code is in the code base. Presumably, it still gets run. It doesn't make a difference if new code doesn't look like that.
- seleniumbase 2y agoCall it "legacy code" if you'd like. That specific part is from a less common feature for setting options when running on a Selenium Grid. The new CDP Mode isn't compatible with The Grid (since CDP Mode makes direct CDP API calls without making Selenium API calls).
- MstWntd 2y agoit's always easier for people today to look at the work of other people in the past and draw stupid conclusions.. don't mind them..
- wisty 2y agoBad old code has been battle tested. Bad new code has not, and is more likely to have the show stopper bugs you want to avoid.
- seleniumbase 2y agoThere's actually a lot of examples being used for testing (https://github.com/seleniumbase/SeleniumBase/tree/master/examples https://github.com/seleniumbase/SeleniumBase/tree/master/exa...), which are run regularly (locally and in GitHub Actions). Plus, a lot of major companies are using SeleniumBase: https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/happy_customers.md https://github.com/seleniumbase/SeleniumBase/blob/master/hel... (if something breaks, I find out quickly)