3 ms·
Neat! I was looking for something like this the other day. Some feedback on the Dockerfiles - I'd recommend instead of trying to mount in the source code as vo
by smcleod 2y ago
Neat! I was looking for something like this the other day.
Some feedback on the Dockerfiles - I'd recommend instead of trying to mount in the source code as volumes, clone the repo in the Docker build process. That will be a lot more reliable and make it easier for people to deploy.
You'll also need to call out if any volumes are required to be mounted to persist data (config files, sqlite databases, cache etc...)
E.g. something like this -
Dockerfile.backend:
FROM python:3.12
RUN apt-get update && apt-get install -y git && apt-get clean && rm -rf /var/lib/apt/lists/*
RUN git clone --depth=1 https://github.com/PySpur-Dev/PySpur.git /pyspur
WORKDIR /pyspur/backend
RUN pip install -r requirements.txt
VOLUME ["/data"]
CMD ["bash", "/pyspur/backend/entrypoint.sh"]
Dockerfile.frontend:
FROM node:alpine
RUN apk add --no-cache git
RUN git clone --depth=1 https://github.com/PySpur-Dev/PySpur.git /pyspur
WORKDIR /pyspur/frontend
RUN npm install
CMD [ "npm", "run", "serve"]
- t55 2y agoThis is excellent feedback, thank you so so much! We will simplify the Dockerfiles soon. Please let us know if we can help you get started!