4 ms·

It's probably time to stop recommending Clean Code: https://qntm.org/clean https://qntm.org/clean I don’t want to be a hater but a lot of “Uncle Bob’s” advice

by omcnoe 2y ago

It's probably time to stop recommending Clean Code: https://qntm.org/clean https://qntm.org/clean I don’t want to be a hater but a lot of “Uncle Bob’s” advice just doesn’t seem very good, this article included. Robert has had a long and successful career writing books on code style and architecture diagrams, but he hasn’t built anything notable in industry during that period. And the opinion presented here seems to clash with nearly everybody who has ever actually built a successful startup. Some things you have to learn by doing.

Etheryte 2y ago
Yeah, the old adage applies that the people making money and the people writing books on how to make money are different people.
- kristiandupont 2y ago
  Also known as "those who can't do, teach".
  - ethbr1 2y ago
    Having heard that, I'd caveat that with "Sometimes, those who have already done, teach." Which then boils down to the student caution to ascertain whether the advice a solid professor is giving you has changed, since they last successfully did. And also the observation that the number of students who are likely to be more successful ignoring education is pretty small: most people aren't that brilliant and will get better mileage out of learning and...
  - fuzztester 2y ago
    also known as those who can't do either (only), comment.
- fuzztester 2y ago
  https://news.ycombinator.com/item?id=42353615 https://news.ycombinator.com/item?id=42353615
peterkelly 2y ago
Why not debate the points in the article on their own merits? Which parts do you agree or disagree with, and why?
- omcnoe 2y ago
  I disagree with the idea that “The start-up phase is not different” and that engineers should follow the same set of good engineering principles regardless of company age. It’s just not true. Anyone who has worked in industry has experienced “good engineering principles” standing in the way of actually succeeding as a business. And other than that point it’s just a badly written article. Yeah it’s fun to read and has swear words in it but Bob doesn’t actually back up any of his points with supporting arguments, the whole thing is just a polemic. And the reason for this lack of supporting arguments is that Bob doesn’t have any industry experience to draw on so he can’t provide any first hand accounts to support his opinion. It’s nothing but grand sweeping statements about an area he has zero familiarity with.
  - marginalia_nu 2y ago
    Yeah. I think there's something like scaling laws for development teams. A number of things change, the cost of refactoring, the cost of communication, the need for communication, the plausibility of everyone knowing everything, etc. Practices that are necessary for a large team can really hamstring a small team. When you're just a few people, you can cut corners larger organizations can not. If you really lean into that, you can kinda run circles around those larger organizations with just a few developers. Technical debt is probably the biggest thing that changes with size. With a small team it's a tool you can use to get more done, a bit like a mortgage can let you do things you couldn't otherwise. Refactoring is cheap when you are few, so you can usually pay it off it gets too bad. Technical debt in large project with many developers is very different, as large refactoring operations are prohibitively expensive, and you should go to great lengths to ensure it doesn't increase.
deleted 2y ago
[deleted]
trentnix 2y ago
While "Uncle Bob" certainly hasn't uncovered any silver bullets, I find the criticism of him to be generally unfair. It's the same type of criticism that commonly targets anyone that actually sticks their neck out far enough to make concrete recommendations. So many teachers, careful not to invite the ire of the armchair critic and ACKCHYUALLY know-it-all, will hem and haw, leading you into analysis paralysis regarding "best practices". That then leads to exhortations to "find what works best for you", acknowledging there are many "right" ways among all the wrong ways. As I've gotten older, I appreciate teachers like Uncle Bob who provide a specific prescription and says "try it this way". I've discovered I learn faster starting somewhere concrete.
- omcnoe 2y ago
  I think the problem I have with Bob is that he doesn’t say "try it this way". He says “you must do it this way, and if you don’t do it this way you are a disgrace to the profession”. Its obnoxious.
  - herpdyderp 2y ago
    Even worse, his cultish followers who blindly believe everything he says without understanding it. “Why must it be done this way?” I ask. “Because Bob said so”. Without comprehension, his advice becomes toxic. If you’re new and you simply don’t get it yet, that’s fine. If you think you’re now an all knowing being because you listen to Bob, please calm down.
    - teddyh 2y ago
      All non-political critiques which I have seen (here and elsewhere) always seem to turn out to be based on misunderstandings or exaggerations of what he actually has said or written (sometimes wildly so). Or, as it sometimes turns out, people hate him not for anything he has said, but because of how other people has misunderstood and misinterpreted him. From what I have seen, every time he has been criticized sincerely, and he has become aware of it, he has engaged his critics in open debate, and they have come to amicable results, with him sometimes altering his views.
cleanerbob 2y ago
[dead]
abofh 2y ago
Your entire comment was "he used to be good at many things, but things I won't talk about have not been to my approval". You presented no facts, no thoughts, just said "others say" you are disinformation, because I'm less informed reading your comment then I was before

by omcnoe 2y ago

Etheryte 2y ago

Yeah, the old adage applies that the people making money and the people writing books on how to make money are different people.

kristiandupont 2y ago
Also known as "those who can't do, teach".
- ethbr1 2y ago
  Having heard that, I'd caveat that with "Sometimes, those who have already done, teach." Which then boils down to the student caution to ascertain whether the advice a solid professor is giving you has changed, since they last successfully did. And also the observation that the number of students who are likely to be more successful ignoring education is pretty small: most people aren't that brilliant and will get better mileage out of learning and...
- fuzztester 2y ago
  also known as those who can't do either (only), comment.
fuzztester 2y ago
https://news.ycombinator.com/item?id=42353615 https://news.ycombinator.com/item?id=42353615

peterkelly 2y ago

Why not debate the points in the article on their own merits? Which parts do you agree or disagree with, and why?

omcnoe 2y ago
I disagree with the idea that “The start-up phase is not different” and that engineers should follow the same set of good engineering principles regardless of company age. It’s just not true. Anyone who has worked in industry has experienced “good engineering principles” standing in the way of actually succeeding as a business. And other than that point it’s just a badly written article. Yeah it’s fun to read and has swear words in it but Bob doesn’t actually back up any of his points with supporting arguments, the whole thing is just a polemic. And the reason for this lack of supporting arguments is that Bob doesn’t have any industry experience to draw on so he can’t provide any first hand accounts to support his opinion. It’s nothing but grand sweeping statements about an area he has zero familiarity with.
- marginalia_nu 2y ago
  Yeah. I think there's something like scaling laws for development teams. A number of things change, the cost of refactoring, the cost of communication, the need for communication, the plausibility of everyone knowing everything, etc. Practices that are necessary for a large team can really hamstring a small team. When you're just a few people, you can cut corners larger organizations can not. If you really lean into that, you can kinda run circles around those larger organizations with just a few developers. Technical debt is probably the biggest thing that changes with size. With a small team it's a tool you can use to get more done, a bit like a mortgage can let you do things you couldn't otherwise. Refactoring is cheap when you are few, so you can usually pay it off it gets too bad. Technical debt in large project with many developers is very different, as large refactoring operations are prohibitively expensive, and you should go to great lengths to ensure it doesn't increase.

deleted 2y ago

[deleted]

trentnix 2y ago

While "Uncle Bob" certainly hasn't uncovered any silver bullets, I find the criticism of him to be generally unfair. It's the same type of criticism that commonly targets anyone that actually sticks their neck out far enough to make concrete recommendations. So many teachers, careful not to invite the ire of the armchair critic and ACKCHYUALLY know-it-all, will hem and haw, leading you into analysis paralysis regarding "best practices". That then leads to exhortations to "find what works best for you", acknowledging there are many "right" ways among all the wrong ways. As I've gotten older, I appreciate teachers like Uncle Bob who provide a specific prescription and says "try it this way". I've discovered I learn faster starting somewhere concrete.

omcnoe 2y ago
I think the problem I have with Bob is that he doesn’t say "try it this way". He says “you must do it this way, and if you don’t do it this way you are a disgrace to the profession”. Its obnoxious.
- herpdyderp 2y ago
  Even worse, his cultish followers who blindly believe everything he says without understanding it. “Why must it be done this way?” I ask. “Because Bob said so”. Without comprehension, his advice becomes toxic. If you’re new and you simply don’t get it yet, that’s fine. If you think you’re now an all knowing being because you listen to Bob, please calm down.
  - teddyh 2y ago
    All non-political critiques which I have seen (here and elsewhere) always seem to turn out to be based on misunderstandings or exaggerations of what he actually has said or written (sometimes wildly so). Or, as it sometimes turns out, people hate him not for anything he has said, but because of how other people has misunderstood and misinterpreted him. From what I have seen, every time he has been criticized sincerely, and he has become aware of it, he has engaged his critics in open debate, and they have come to amicable results, with him sometimes altering his views.

cleanerbob 2y ago

[dead]

abofh 2y ago

Your entire comment was "he used to be good at many things, but things I won't talk about have not been to my approval". You presented no facts, no thoughts, just said "others say" you are disinformation, because I'm less informed reading your comment then I was before