8 ms·
I would rather have a messy commit history with all of the value that an audit trail brings va a clean history that purges said context.
by tmountain 2y ago
I would rather have a messy commit history with all of the value that an audit trail brings va a clean history that purges said context.
- leoqa 2y agoHere ya go: commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. merge main commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. fml commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. fix 2 commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. fix 1 commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. CI fix commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. PR comments commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. Linter commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. Fix test commit f5b5bd8f9eaa443d4020cbe918x742e7ddd22000 Author : John Doe <John.Doe@mail.com> Date: Mon May 22 14:21:03 2023 -0400. Implement new SSO feature
- yjftsjthsd-h 2y agoSo? Even without good commit messages `git blame` will tell us who touched what and when.
- dzaima 2y agoNot necessarily; if one commit touches all lines (or a bunch), and another reverts that, the blame is thrashed; much worse than having rebased the temp change away. And a commit name of "." is quite significantly less useful in a git blame than "Rewrite foo to use new thing" when looking at reasons for why foo might have broken.
- WolfeReader 2y agoIs the reuse of the commit hash and date intentional and part of the joke? Besides that, I like seeing and preserving this kind of history. And when I don't want to, there are ways to filter the logs.
- falcojr 2y agoHow is a "PR comments" commit useful to you? If I'm looking at history, it's usually to see: 1. What caused a bug 2. Context around a feature and why it was written a certain way Seeing a "PR comments" commit just turns into noise. It also makes me gather 10 commits together to try to piece back together the unit of work that was built. I just see no value in preserving this type of noise.
- WolfeReader 2y agoThat is a perfect example. The "PR comments" commit helps me see what the dev considered most important (code before this commit), and what the rest of the team considered lacking (the content of this commit). Thus, the Git history records a facet of the team culture at the time of the commit.
- leoqa 2y agoIn my experience the merge commit is simply a reference to the PR, which has all the context. The title of the PR is effectively the commit summary.
- eviks 2y agoNo, you're making up that story and that culture, and when you lose this spurious foundation, you'll just as easily make up some other story based on any other random data. For example, reality could've been that there was no team involved at all and all those changes came to the original person the moment he made the PR. And the "PR comments" could just as easily refer to his own comments he added during when checking those CI messages and noticing something else and commenting on that not to forget.
- dzaima 2y ago