3 ms·
style fixes should always be separate commits. if they fix a PR, they should be part of that PR or an independent PR, but ideally not included in the next code
by em-bee 2y ago
style fixes should always be separate commits. if they fix a PR, they should be part of that PR or an independent PR, but ideally not included in the next code changing PR
- chipdart 2y ago> style fixes should always be separate commits. Not really. If you're already changing the code and running linters afterwards introduces changes over your change, this means you are the one introducing the problems. Separate commits just add noise. Your comment is like saying that bug fixes should be separate commits when arguing about how not to add bugs to begin with.
- em-bee 2y agook, yes, you should not introduce style problems to begin with. but if the problem is already there from an older PR, it should be fixed separately.