3 ms·
> IMO the best way to handle stylistic choices (if at all) is to have the reviewer just adjust it themselves. How does that inform the PR author that they fail
by chipdart 2y ago
> IMO the best way to handle stylistic choices (if at all) is to have the reviewer just adjust it themselves.
How does that inform the PR author that they failed to pay attention to a relevant detail, and more importantly contribute to not make it again?
If there is no feedback, problems will persist.
Nit comments add noise and failures to comply with a style guide is always a distraction on a PR, but that does not mean style guide violations should be ignored. It means that your team must work their way into making them a non-issue.
This means establishing an objective and usable set of rules and guidelines, and enforce them programmatically with a linter, not turning a blind eye to style violations.